Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#5782 closed enhancement (fixed)

Differ "Admin" from "to admin"

Reported by: Dianakc Owned by: djpaul
Milestone: 2.1 Priority: normal
Severity: normal Version:
Component: I18N Keywords:
Cc: danco38@…

Description

Hi there,

I'm testing pt_BR translation and everything is great though I found some places where "Admin" can't be proper translated, I think would be useful differ "Admin" (n. user role) from Admin (v. "to administer").

Change History (11)

#1 @DJPaul
5 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

Sure, but we'll need at least a list of files/line numbers where you think these instances should be changed (a patch would be even better).

#2 @danbp
5 years ago

  • Cc danco38@… added

There is only one instance with Admin (bp-groups-loader.php:476), intended for My Group nav menu

This is also disambiguate in #5777 patch

The other strings containing "admin" are (lines # refering to 2.1 trunk):
Administrator (bp-groups-admin.php:816)
Administrators (bp-groups-admin.php:776 and bp-legacy/buddypress/groups/single/admin.php:177)
Administrator of (bp-groups/bp-groups-template.php:2891 & 2919)

Any other allusion to "admin" is probably a use effect of the default username at wp installation, a theme or 3thd party plugin.

#3 @DJPaul
5 years ago

  • Keywords 2nd-opinion needs-patch removed
  • Milestone changed from Future Release to 2.1

Thanks for joining the conversation, danbp.

Dianakc, thanks for your feedback, too. In #5777, danbp has a patch which adds context to more strings in BuddyPress. We will be adding that patch to BuddyPress very soon. After it's been committed into BuddyPress, it would be great if you could then check for "Admin" again and see if there are more improvements we can still make.

#4 @DJPaul
5 years ago

Dianakc -- danbp's change has been added.

#5 @DJPaul
5 years ago

  • Milestone 2.1 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Decided to mark this ticket invalid based on danbp's feedback. We need more feedback from Dianakc to help us identify any "Admin" strings that we've overlooked.

#6 @Dianakc
5 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

Hi there,

I find the "Admin" as a tab item when viewing a group page where it shows four tabs: "Home", "Members", "Send invites" and then "Admin", I think could be "Manage".

#7 @netweb
5 years ago

  • Milestone set to Awaiting Review

#8 @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to 2.1

Thanks Dianakc -- good suggestion.

#9 @djpaul
5 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from reopened to closed

In 8982:

Groups: rename the administration "Admin" navigation item to "Manage" to disambiguate the string.

Fixes #5782, props Dianakc

#10 @DJPaul
5 years ago

I committed a string change because translate.wordpress.org/buddypress still isn't working correctly (#5621).

#11 @DJPaul
3 years ago

  • Component changed from Locale - i18n to I18N
Note: See TracTickets for help on using tickets.