Skip to:
Content

Opened 4 years ago

Closed 4 years ago

#5697 closed enhancement (fixed)

New class to style visibility levels

Reported by: SGr33n Owned by: boonebgorges
Milestone: 2.1 Priority: normal
Severity: normal Version:
Component: Settings Keywords: has-patch
Cc:

Description

Hi,

As anticipated on https://buddypress.trac.wordpress.org/ticket/5693, I would suggest to add a class for visibility settings level radio buttons, in order to make it possible to style them with icons.

So there is a patch to make it.

Attachments (1)

patch-li-class-visibility-level.patch (1.1 KB) - added by SGr33n 4 years ago.

Download all attachments as: .zip

Change History (4)

#1 @DJPaul
4 years ago

  • Component changed from Core to Settings
  • Milestone changed from Awaiting Review to 2.1

Thanks for the patch. The request seems reasonable.

We'll need to adjust the patch, slightly: printf( $r['before_radio'], $level['id'] ) should be printf( $r['before_radio'], esc_attr( $level['id'] ) ) in case someone figures out a way of inserting harmful XSS-type markup into the class= property. It also helps from a code review perspective that we know the output's being escaped safely in case a future change to BuddyPress accidentally introduces a problem.

#2 @SGr33n
4 years ago

Good :)

Thanks r-a-y!

#3 @boonebgorges
4 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 8606:

Add a CSS class to xprofile visibility radio buttons describing the visibility value

Fixes #5697

Props SGr33n

Note: See TracTickets for help on using tickets.