Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 6 years ago

#5698 closed enhancement (maybelater)

Extract extract()

Reported by: boonebgorges's profile boonebgorges Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords: trac-tidy-2018
Cc:

Description

See upstream ticket: https://core.trac.wordpress.org/ticket/22400

Broadly speaking, uses of extract() are pointless at best, and obfuscatory at worst. Let's use this ticket as a reference for removing instances of extract() throughout BuddyPress.

Change History (14)

#1 @boonebgorges
10 years ago

In 8517:

Don't use extract() in bp_activity_get()

See #5698

#2 @boonebgorges
10 years ago

In 8519:

Don't use extract() in bp_activity_get_specific()

See #5698

#3 @boonebgorges
10 years ago

In 8520:

Don't use extract() in bp_activity_add()

See #5698

#4 @boonebgorges
10 years ago

In 8522:

Don't use extract() in bp_activity_post_update()

See #5698

#5 @boonebgorges
10 years ago

In 8525:

Don't use extract() in bp_activity_new_comment()

See #5698

#6 @boonebgorges
10 years ago

In 8527:

Don't use extract() in bp_activity_get_activity_id(). See #5698

#7 @boonebgorges
10 years ago

In 8529:

Don't use extract() in bp_activity_delete_by_item_id().

See #5698

#8 @boonebgorges
10 years ago

In 8534:

Don't use extract() in xprofile_insert_field()

This one was particularly heinous.

See #5698

#9 @boonebgorges
10 years ago

In 9125:

Don't extract() in bp_core_fetch_avatar(), and pass params to 'bp_core_fetch_avatar_no_grav' hook.

Passing the modified parameters to the hook required moving away from the use
of extract(). See #5698.

Props dcavins.
Fixes #5958.

#10 @boonebgorges
10 years ago

In 9213:

Don't use extract() in BP_Activity_Activity::get().

Props r-a-y.
See #5698, #4988.

#11 @johnjamesjacoby
9 years ago

In 9536:

Activity: Clean up bp_has_activities():

  • Remove $bp global usage. See #5138.
  • Remove extract() usage. See #5698.
  • Remove one-time-use variables.
  • Consolidate arrays for improved readability.

#12 @DJPaul
8 years ago

  • Type changed from task to enhancement

#13 @DJPaul
6 years ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#14 @DJPaul
6 years ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.