#5693 closed defect (bug) (fixed)
bp_profile_visibility_radio_buttons() misses id in label
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.0.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Extended Profile | Keywords: | |
Cc: |
Description
Hi,
In the html returned by bp_profile_visibility_radio_buttons() missing the id value for the label tag. The result is that you cannot click on the text.
example code:
<label for=""> <input id="see-field_2_public" type="radio" checked="checked" value="public" name="field_2_visibility"> <span class="field-visibility-text">Everybody</span> </label>
Reason: echo missing
Attachments (4)
Change History (14)
#2
@
10 years ago
- Keywords needs-refresh added; has-patch removed
Thanks for creating the ticket and for the patches, SGr33n.
However, your patch format does not work well with our dev workflow.
Can you try creating SVN-compatible patches?
http://make.wordpress.org/core/handbook/working-with-trac/submitting-a-patch/
If you are on Windows and prefer using a GUI rather than command-line, try out Tortoise SVN to create the patch:
http://make.wordpress.org/core/handbook/working-with-patches/create-a-patch-using-tortoisesvn/
#6
@
10 years ago
- Component changed from Core to XProfile
- Keywords needs-refresh removed
SGr33n - Thanks very much for the properly formatted patch!
The missing echo
appears to be a bug that was introduced in r8210, and thus is a regression in BP 2.0. I'm going to put this ticket into 2.0.2 for that reason.
Your request to add classes to the <li>
elements seems fine to me, but should go into the 2.1 milestone instead. Would you mind opening a separate ticket that explains the justification for this enhancement, and post a new patch there? Thanks!
The second patch also adds classes for radio buttons li containers, in order to make it possible to style them e.g. with an icon.
Before:
Patch applied: