Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#5559 closed defect (bug) (fixed)

Signups Management: Activate method trouble

Reported by: imath Owned by:
Milestone: 2.0.1 Priority: high
Severity: major Version: 2.0
Component: Core Keywords: has-patch commit
Cc:

Description

In BP_Signup::activate(), in case of an error, we should first try to get the user_id before checking for his status. As he's not defined the way it's done now.

With this patch, if the activate action is requested, when a user is already activated, he will disappear from the pending account.

Attachments (1)

5559.diff (792 bytes) - added by imath 6 years ago.

Download all attachments as: .zip

Change History (6)

@imath
6 years ago

#1 @boonebgorges
6 years ago

  • Keywords commit added; 2nd-opinion removed

Yes, this fix looks right to me.

#2 @simple-man
6 years ago

Gentlemen,

Will this fix the "Invalid Activation Key" error?
Just wondering because this issue has me stuck for over a month now.

Thank you.

#3 @imath
6 years ago

In 8293:

In BP_Signup::activate(), make sure the user ID is defined before checking user_status

When Activating a signup from the Signups management screen, in case of an error, we need to first try to get the user id before checking his status.

see #5559

#4 @r-a-y
6 years ago

Will this fix the "Invalid Activation Key" error?

No, that is separate and is something that is occurring when a user activates their account from the link in their activation email.

Your issue might be related to #5288. If it isn't, open a new ticket and let us know.

#5 @imath
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r8294

Note: See TracTickets for help on using tickets.