Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#5469 closed enhancement (fixed)

Create a group button - create screen steps

Reported by: hnla's profile hnla Owned by: boonebgorges's profile boonebgorges
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: Groups Keywords:
Cc:

Description

Need to revisit the patches put in place for the removal of the group create button being passed into the title tag ticket #5144.

On the group creation steps we still have the anchor link being passed through.

I'm not sure why when we are now on the group create steps we need a link as it simply refreshes to the same page, seems to make sense we de-link the text?

If not de-link then apply the same filtering to line 1124 in bp-groups-screens.php in the 'create_dummy_post' function for the create steps as we did earlier for 'directory_dummy_post line 1066; so that template pack and other themes can loose this behaviour altogether.

Attachments (1)

5469.patch (766 bytes) - added by boonebgorges 10 years ago.

Download all attachments as: .zip

Change History (4)

#1 @boonebgorges
10 years ago

  • Milestone changed from Awaiting Review to 2.0

Seems to me that we can remove the text altogether. If you're creating a group, why do you need a Create a Group button? See 5469.patch.

@boonebgorges
10 years ago

#2 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 8164:

Don't show the "Create a Group" button in the page title during the group creation process

Fixes #5469

#3 @hnla
10 years ago

Yep my vote would have been to simply remove altogether, it's utterly redundant, although there may be someone that throws hands up in horror when it vanishes *shrug*.

On a sidenote: bad bad bad trac why you no send notification to ticket author when it's updated very frustrating, have to remember to CC oneself in on a ticket you just wrote!

Note: See TracTickets for help on using tickets.