Skip to:
Content

BuddyPress.org

Opened 7 years ago

Last modified 6 years ago

#4875 assigned defect (bug)

@mention notifications NOT being sent if @mention falls out of excerpt limit in forum posts.

Reported by: rossagrant Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version: 1.6.4
Component: Toolbar & Notifications Keywords: needs-patch
Cc:

Description

I noticed that some of my user's weren't getting @mention email notifications today and have done some testing.

I have found that if you use an @mention further down a forum reply in BBPress for example, or at the end of a longer comment on a WP post that an @mention notification email is not sent.

I have tested this on a vanilla install of WP 3.5.1/ BP 1.6.4/ BBPress 2.2.4

Steps to reproduce:

Post the following text in a WP comment or BBPress forum post:

  1. @mention at the start - will receive email notification:

@admin Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.

  1. @mention much further down - resulting in NO email notification sent:

Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum. @admin check this out!

It appears that any @mention that falls outside the excerpt that gets posted in the activity stream and also appears in the notification email itself won't get processed.

Sometimes on my site I will refer to many people by @mention at various points in a post to make sure they get a notification, so it would be great to work out why this isn't working!

Let me know if you need me to test as usual!

Change History (8)

#1 @rossagrant
7 years ago

Just to clarify, the @mention itself still works as a link to a member's profile, it's purely the notification email that isn't firing when a mention is used further down a comment/ reply.

#2 @r-a-y
7 years ago

Tried snippet no. 2 on BP 1.7-beta-2 / bbP 2.3-bleeding and it works for me.

However, the post permalink in the @mention email doesn't add the HTTP host and is incorrect:

eg.
/groups/bbpress-forum/forum/reply/my-topic/#post-74

Note the missing HTTP host and the "reply" slug.

This is similar to #BB2038, but slightly different.

Last edited 7 years ago by r-a-y (previous) (diff)

#4 @rossagrant
7 years ago

Hey R-a-y/ Boone,

Cool, so this was always intended behaviour with @mentions.

Does this mean that it is enhanced now if snippet 2 above is working or r-a-y?

The @mention in snippet 2 should be far enough after the text to be out of the excerpt?

#5 @r-a-y
7 years ago

Does this mean that it is enhanced now if snippet 2 above is working or r-a-y?

Yes, with snippet 2, the @mention does not show up in the excerpt, but I get the @mention email. I made some changes in BP 1.7 to the way @mentions were parsed so indirectly, that fixed your problem above. Wrong: JJJ fixed this in bbP trunk - [BB4789].

However, the issue I talk about in comment 2 still applies with bbPress.

Last edited 7 years ago by r-a-y (previous) (diff)

#6 @johnjamesjacoby
7 years ago

  • Keywords needs-patch added
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

#7 @DJPaul
7 years ago

  • Milestone changed from Awaiting Review to Future Release

#8 @johnjamesjacoby
6 years ago

  • Owner johnjamesjacoby deleted
Note: See TracTickets for help on using tickets.