Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 11 years ago

#4380 closed defect (bug) (fixed)

Add screen reader text to checkboxes in list tables

Reported by: djpaul's profile DJPaul Owned by: modemlooper's profile modemlooper
Milestone: 1.8 Priority: normal
Severity: normal Version:
Component: Administration Keywords: needs-refresh
Cc:

Description

Add screen reader text to checkboxes in list tables -- currently, only the Activity admin screens use a list table. See #WP21325 for implementation example.

Putting in 1.7-early because this would involve a new string, and 1.6 is in string freeze.

Attachments (1)

4380.patch (521 bytes) - added by modemlooper 12 years ago.

Download all attachments as: .zip

Change History (9)

#1 @boonebgorges
12 years ago

  • Keywords needs-patch removed
  • Milestone changed from Future Release to 1.7

#2 @DJPaul
12 years ago

  • Keywords needs-patch added

#3 @modemlooper
12 years ago

  • Owner set to modemlooper
  • Status changed from new to assigned

#4 @modemlooper
12 years ago

  • Keywords has-patch needs-testing added

I just added the string "Select activity_id" as the identifier. Not sure what text would be required for a screen reader. Maybe "Activity activity_id" or "Select Activity activity_id" ?

@modemlooper
12 years ago

#5 @johnjamesjacoby
11 years ago

  • Keywords needs-refresh added; 1.7-early needs-patch has-patch needs-testing removed
  • Milestone changed from 1.7 to 1.8

Patch is incomplete; punting to 1.8.

#6 @boonebgorges
11 years ago

modemlooper - I'd say you can use something more English-language descriptive here. Just "Select activity" is probably fine.

Would you mind refreshing this patch for the Groups screen as well? bp-groups/bp-groups-admin.php

#7 @hnla
11 years ago

If those labels are not going to wrap the input forming an 'implicit' relationship then an explicit relationship must be stated i.e the 'for' attr should be used.

Why, out of interest, are those form controls being added to translatable text? does that not run the danger of a bad translated string breaking the markup?

#8 @boonebgorges
11 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7197:

Adds screen-reader-text labels to List_Table checkboxes

Fixes #4380

Props modemlooper for initial patch

Note: See TracTickets for help on using tickets.