Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#4379 closed defect (bug) (fixed)

bp_core_get_active_member_count() not network-aware

Reported by: boonebgorges's profile boonebgorges Owned by: boonebgorges's profile boonebgorges
Milestone: 1.6 Priority: normal
Severity: normal Version: 1.6
Component: Core Keywords: has-patch
Cc:

Description

The new query in bp_core_get_active_member_count() does not make its last_activity key network-relative.

Attachments (1)

4379.01.patch (886 bytes) - added by DJPaul 12 years ago.

Download all attachments as: .zip

Change History (6)

@DJPaul
12 years ago

#1 @DJPaul
12 years ago

  • Keywords has-patch added

Attached a patch for review. Is it as straightforward as that?

#2 @boonebgorges
12 years ago

Thanks, DJPaul - I was too busy to do this last night when I noticed it.

Your idea is right, but you have to make sure that you put the parens in the right place, or the arguments won't be swapped :)

#3 @boonebgorges
12 years ago

(I'm about to commit the change, but I'm having git-svn issues)

#4 @boonebgorges
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6197]) Pass 'last_activity' key through bp_get_user_meta_key() in bp_core_get_active_member_count()

This ensures that the All Members tab count will be accurate and network-
specific in multinetwork setups.

Fixes #4379

Props DJPaul

#5 @johnjamesjacoby
9 years ago

  • Version changed from 1.6-rc to 1.6
Note: See TracTickets for help on using tickets.