Skip to:
Content

Opened 4 years ago

Closed 2 years ago

#3388 closed enhancement (fixed)

Allow @mentions to be disabled

Reported by: cnorris23 Owned by: boonebgorges
Milestone: 1.8 Priority: normal
Severity: normal Version: 1.5
Component: Component - Activity Keywords: has-patch needs-refresh
Cc: vpundir@…

Description

BuddyPress No Mentions by r-a-y handles this well, but with over 2,000 downloads in less than a year it seems like a good candidate for core adoption. I've included two patches, one with an option added to the BP settings page, the other is a filter only scenario. I've added the bp_activity_do_mentions() function to bp-activity-filters.php because bp-activity-functions.php wasn't being loaded early enough, and I wasn't sure about changing load order.

Attachments (4)

3388.001.diff (10.4 KB) - added by cnorris23 4 years ago.
filter only
3388.002.diff (14.6 KB) - added by cnorris23 4 years ago.
admin option
3388.003.diff (10.4 KB) - added by cnorris23 4 years ago.
updated filter only
3388.004.patch (10.3 KB) - added by thebrandonallen 2 years ago.

Download all attachments as: .zip

Change History (17)

@cnorris234 years ago

filter only

@cnorris234 years ago

admin option

comment:1 @boonebgorges4 years ago

  • Keywords dev-feedback added

I like the idea of including something like this. Don't think we need an admin option, personally, so I would go with the first option. Only question is milestone - do we squeeze into 1.3? Other core devs chime in?

comment:2 @cnorris234 years ago

I agree that the filter would be better, but wanted to cover my bases. Also, I'm updating the filter only patch. It was defaulting to mentions disabled.

@cnorris234 years ago

updated filter only

comment:3 @DJPaul4 years ago

  • Type changed from defect to enhancement

I don't mind a filter in core, but I personally think that DTheme should showcase all of BuddyPress' best features, and I think @messaging is one of them (= no conditional changes in DTheme). This is an enhancement not a defect, and now we are in beta, it should go to a future release.

comment:4 @boonebgorges4 years ago

  • Milestone changed from Awaiting Review to Future Release

I personally think that DTheme should showcase all of BuddyPress' best features, and I think @messaging is one of them

Fair enough. This is a good argument for not having the conditional in bp-default.

Moving to Future Release, which should get a good going-through after the 1.5 release.

comment:5 @DJPaul3 years ago

  • Milestone changed from Future Release to 1.7

Let's reconsider as we build the theme compat stuff; if nothing else, we can get a filter in.

comment:6 @sooskriszta3 years ago

  • Cc vpundir@… added

Admin option would be great!

Personally, as a site-owner (as opposed to developer), I find filter-only features hard to reconcile with...it feels like the heavy lifting has already been done in the back-end but the last mile hasn't been built rendering the feature useless to most users...

comment:7 @modemlooper3 years ago

you can turn this off by adding a code snippet or using bp extended settings plugin.

comment:8 @johnjamesjacoby3 years ago

  • Milestone changed from 1.7 to 1.8

Looks like 3388.002.diff​ went stale. Let's get a refresh in for 1.8?

comment:9 @boonebgorges2 years ago

  • Keywords needs-refresh added; dev-feedback removed

I think cnorris23's patches are good, but need refreshing to be included in 1.8. (No whitespace fixes, please.)

comment:10 @thebrandonallen2 years ago

Patch refresh from the artist formally know as cnorris23. I was unsure which patch I was supposed to refresh, so I just picked the most recent one, 3388.003.diff, the patch without the admin option. I can add the admin option back in if desired. I also did not patch bp-legacy, as I wasn't sure about protocol there. There are only 2-3 spots that need work, so adding that in won't be a problem either.

@thebrandonallen2 years ago

comment:11 @sooskriszta2 years ago

Good stuff.

+1 for admin option.

comment:12 @boonebgorges2 years ago

Thanks for the refresh thebrandonallen! Looks very close to being ready. A couple thoughts:

  • Looks like you're missing a ! in the bp-activity-template.php part of 3388.004.patch
  • Re bp-default and bp-legacy. We definitely want to patch bp-legacy. I'm not totally sure what our policy on bp-default is at this point. I guess let's go ahead and leave the fix in there too, and maybe after 1.8 we can talk as a team about a more formal feature freeze on bp-default.

comment:13 @boonebgorges2 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7193:

Introduces bp_activity_do_mentions(), a toggle for the activity mentions feature

Fixes #3388

Props thebrandonallen

Note: See TracTickets for help on using tickets.