Xprofile - alignment and shades

[ezd]

Please see the attached screenshot for details.

• The alignment is broken on IE (don't know about other browsers)
• Some background shades are missing

[DJPaul]

What version IE did you test on? IE9 seems fine.

[ezd]

Safari 5. Sorry, haven't tested other browsers.

[DJPaul]

Safari 5 on Mac works fine for me, too. Per your screenshot, your xprofile table looks to be twice as tall as mine is. I'm not sure how a clean install here is different from a clean install on your end.

[DJPaul]

Can you recreate this on the current trunk or on testbp?

[johnjamesjacoby]

I can see where it's wrong. Moving to 1.3.

[DJPaul]

Any clues? :)

[boonebgorges]

The problem is that we do a global reset of p margin-bottom, and follow it up with p:last-child margin-bottom: 0. IE8 does not understand :last-child.

However, IE8 does support :first-child. 3222.diff reorganizes paragraph margins in such a way that it uses :first-child, but should have the same net effect.

[DJPaul]

I think this is ok to do for these tags, because they pretty much break the layout of the page. Remember to do the same in editor-style.css.
FWIW, I don't think it's a good idea for us to go through and replace any of the other :last-child selectors because we'll likely break the design. I think we should, if we find any other IE8 :last-child issues while in beta, look at those on a case-by-case.

[boonebgorges]

(In [4807]) Fixes alignment of xprofile data in IE and other browsers that don't recognize :last-child. Just kidding, there are no other browsers that don't recognize :last-childe. Fixes #3222

[boonebgorges]

Apparently the changes in r4807 are messing other stuff up, so these styles should be made more specific.

[boonebgorges]

(In [4852]) Reverts changes in r4807 and makes last-child padding more specific to profile fields. Fixes #3222

[boonebgorges]

(In [4853]) Reverts r4807 for editor stylesheet. See #3222