Skip to:
Content

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3221 closed defect (bug) (fixed)

Remove direct usage of CUSTOM_USER_TABLE and CUSTOM_USER_META_TABLE

Reported by: nacin Owned by:
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Core Keywords:
Cc:

Description

These are internal configuration constants for WordPress. Any plugin wishing to reference these should instead use $wpdb->users and $wpdb->usermeta directly.

Attached patch removes initial references. Unfortunately, these values are also loaded up into the bp global for some reason. We'll want to de-couple that as much as possible.

Attachments (1)

bp.3221.diff (13.7 KB) - added by nacin 8 years ago.

Download all attachments as: .zip

Change History (6)

@nacin
8 years ago

#1 @DJPaul
8 years ago

  • Milestone changed from Awaiting Review to 1.3

#2 @DJPaul
8 years ago

I see these stored in the bbPress global -- which are needed for the current version of bbPress -- but I can't find any non-direct references where we set them to the $bp global?

#3 @DJPaul
8 years ago

About to commit this patch; I can't find anything else relevant that's not part of bbPress.

#4 @djpaul
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4444]) Remove direct usage of CUSTOM_USER_TABLE and CUSTOM_USER_META_TABLE. Fixes #3221, props nacin

#5 @nacin
8 years ago

You're right, looks like everything else is in bbPress. Hopefully that can be fixed in due course.

Note: See TracTickets for help on using tickets.