Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#2975 closed defect (bug) (fixed)

Clean up bp-default header.php

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Templates Keywords: has-patch
Cc:

Description

The attached patch cleans up a few things in header.php of the bp-default theme.

Specifically:

  • moves the stylesheet higher up the priority in the <head> tag
  • removes the <meta> generator Wordpress tag as this is already automatically added by Wordpress in the "wp_head" action.
  • removes the hardcoded activity feed links and attaches them to the "bp_head" action. [omission of whitespace is intentional in bp_dtheme_sitewide_feed()]
  • removes some unnecessary blank lines
  • *bonus* removes secondary blog avatars as this wasn't back-patched to trunk.

---

Right now, I've added the feed links in /bp-default/functions.php, but might be better placed in /bp-activity.php. Thoughts?

Like #2764, if committed, child theme authors will have to remove the hardcoded feed links in their header.php to prevent double feeds from appearing in <head>.

Attachments (1)

2975.001.patch (5.2 KB) - added by r-a-y 13 years ago.

Download all attachments as: .zip

Change History (8)

@r-a-y
13 years ago

#1 @djpaul
13 years ago

(In [3594]) Backport r3409 from 1.2 branch into trunk. Props r-a-y (see #2975)

#2 @DJPaul
13 years ago

  • Milestone changed from Awaiting Review to 1.3

#3 @DJPaul
13 years ago

I think your idea of putting the feed links into the component is a better idea than putting it into functions.php, which is getting pretty big.

I'm about to commit your patch with this change, and I put back the whitespace in bp_dtheme_sitewide_feed() as I've hooked those functions into wp_head rather than a custom bp_head action (I don't think we need to introduce that).

#4 @DJPaul
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [r3595] Fixes #2975

#5 @DJPaul
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I have reverted these changes made in r3595 due to my error and will re-patch again correctly :)

#6 @djpaul
13 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3600]) Tidies up default theme's header.php -- removes duplicated generator line and the hardcoded activity feed links and attaches them to bp_head. Fixes #2975, props r-a-y

#7 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.