#2975 closed defect (bug) (fixed)
Clean up bp-default header.php
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 1.5 | Priority: | normal |
| Severity: | Version: | 1.5 | |
| Component: | Templates | Keywords: | has-patch |
| Cc: |
Description
The attached patch cleans up a few things in header.php of the bp-default theme.
Specifically:
- moves the stylesheet higher up the priority in the <head> tag
- removes the <meta> generator Wordpress tag as this is already automatically added by Wordpress in the "wp_head" action.
- removes the hardcoded activity feed links and attaches them to the "bp_head" action. [omission of whitespace is intentional in bp_dtheme_sitewide_feed()]
- removes some unnecessary blank lines
- *bonus* removes secondary blog avatars as this wasn't back-patched to trunk.
---
Right now, I've added the feed links in /bp-default/functions.php, but might be better placed in /bp-activity.php. Thoughts?
Like #2764, if committed, child theme authors will have to remove the hardcoded feed links in their header.php to prevent double feeds from appearing in <head>.
Attachments (1)
Change History (8)
#3
@
14 years ago
I think your idea of putting the feed links into the component is a better idea than putting it into functions.php, which is getting pretty big.
I'm about to commit your patch with this change, and I put back the whitespace in bp_dtheme_sitewide_feed() as I've hooked those functions into wp_head rather than a custom bp_head action (I don't think we need to introduce that).
#5
@
14 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
I have reverted these changes made in r3595 due to my error and will re-patch again correctly :)
(In [3594]) Backport r3409 from 1.2 branch into trunk. Props r-a-y (see #2975)