Skip to:
Content

Opened 3 years ago

Closed 14 months ago

Last modified 14 months ago

#2764 closed defect (bug) (invalid)

Move bp_message_get_notices() to an action

Reported by: r-a-y Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.2.6
Component: Theme Keywords: dev-feedback
Cc:

Description

Right now, we hardcode the notices to the sidebar.

What if we want to show the notices somewhere else and we want to unhook the notices from the sidebar?

Attached patch adds bp_message_get_notices() as an action and allows theme developers to easily remove sidebar notices with remove_action.

Attached patch is against 1.2.6.

---

Only problem is theme developers will need to update their theme so double notices will not show up (similar to the double buttons issue that popped up after v1.2.6 was released).

Attachments (1)

2764.001.patch (941 bytes) - added by r-a-y 3 years ago.

Download all attachments as: .zip

Change History (10)

r-a-y3 years ago

comment:1 DJPaul3 years ago

Why can't sidebar.php be overridden in a stylesheet?

comment:2 boonebgorges3 years ago

DJPaul - Of course sidebar.php *could* be overridden. But hardcoding these sorts of things seems to be bad sportsmanship on BP's part :) If we can save site owners from overriding a bp-default template (and saving them the headache of manually merging future changes into their child theme), then we should do so.

+1 on the patch. Paul, are you strongly against it?

comment:3 r-a-y3 years ago

What Boone said ;)

comment:4 DJPaul3 years ago

  • Keywords dev-feedback added

Yep. I think a widget would be more appropriate. However, as this on itself would be the world's most boring widget, what about combining it with #1474 -- the log in/out panel and the message notices into a combined widget?

comment:5 DJPaul3 years ago

  • Milestone changed from 1.3 to 1.4

Bumping this to 1.4 unless someone provides a good patch.

comment:6 DJPaul3 years ago

  • Keywords has-patch removed

comment:7 DJPaul3 years ago

  • Milestone changed from 1.6 to Future Release
  • Severity set to normal

comment:8 r-a-y14 months ago

  • Resolution set to invalid
  • Status changed from new to closed

Closing this as theme compat now covers sitewide notices (#4802) and is unhookable if someone needs to override it.

comment:9 DJPaul14 months ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.