Move bp_message_get_notices() to an action

[r-a-y]

Right now, we hardcode the notices to the sidebar.

What if we want to show the notices somewhere else and we want to unhook the notices from the sidebar?

Attached patch adds bp_message_get_notices() as an action and allows theme developers to easily remove sidebar notices with remove_action.

Attached patch is against 1.2.6.

---

Only problem is theme developers will need to update their theme so double notices will not show up (similar to the double buttons issue that popped up after v1.2.6 was released).

[DJPaul]

Why can't sidebar.php be overridden in a stylesheet?

[boonebgorges]

DJPaul - Of course sidebar.php *could* be overridden. But hardcoding these sorts of things seems to be bad sportsmanship on BP's part :) If we can save site owners from overriding a bp-default template (and saving them the headache of manually merging future changes into their child theme), then we should do so.

+1 on the patch. Paul, are you strongly against it?

[r-a-y]

What Boone said ;)

[DJPaul]

Yep. I think a widget would be more appropriate. However, as this on itself would be the world's most boring widget, what about combining it with #1474 -- the log in/out panel and the message notices into a combined widget?

[DJPaul]

Bumping this to 1.4 unless someone provides a good patch.

[r-a-y]

Closing this as theme compat now covers sitewide notices (#4802) and is unhookable if someone needs to override it.