Skip to:

Opened 13 years ago

Closed 13 years ago

#2976 closed defect (bug) (fixed)

Group extension admin screen not saving

Reported by: boonebgorges's profile boonebgorges Owned by:
Milestone: 1.5 Priority: major
Severity: Version:
Component: Groups Keywords: has-patch dev-feedback


BP_Group_Extension::edit_screen_save() is not getting called on the latest trunk r3597. The register() method is supposed to hook edit_screen_save() to 'wp' but I am guessing that a load-order problem has been introduced.

Attachments (2)

2976-1.patch (2.1 KB) - added by boonebgorges 13 years ago.
2976-2.patch (2.1 KB) - added by boonebgorges 13 years ago.

Download all attachments as: .zip

Change History (7)

#1 @boonebgorges
13 years ago

After some poking around, an update. The problem lies with bp_core_load_template, which BP_Group_Extension calls in several places. When bp_core_load_template() dies (in order to prevent more output), it stops later actions hooked to the 'wp' hook from firing. Yet for some reason it works in the 1.2 branch, even though the basic principle is the same.

I'll do some more digging. Thoughts welcome, though.

#2 @boonebgorges
13 years ago

I never did figure out exactly why this works in BP 1.2.x but not on the trunk, but 2976-1.patch does fix the problem, by ensuring that the extension's admin template gets loaded very late (giving time for other things hooked to 'wp' to fire).

#3 @boonebgorges
13 years ago

  • Keywords has-patch dev-feedback added

#4 @boonebgorges
13 years ago

This time with correct phpdoc 2976-2.patch

#5 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3609]) Modifies the BP_Group_Extension class to call ->edit_screen_save() directly. Fixes #2976. Removes the die statements in the group extension methods to be overridden by plugins

Note: See TracTickets for help on using tickets.