Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 11 years ago

#2631 closed defect (bug) (no action required)

$disabled_components['bp-blogs.php'] default to FALSE

Reported by: kayue's profile kayue Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

Should be true instead.

The bug I found is I installed BP in a non-multi-site Wordpress, the "Tracks blogs" option isn't showing in admin panel's BuddyPress Component Setup.

At the mean time, $disabled_componentsbp-blogs.php? default to FALSE . Since the option isn't showing in Component Setup page, there is no way I can disable the "Tracks blogs" option.

Attachments (2)

2631.001.patch (583 bytes) - added by r-a-y 13 years ago.
2631.002.patch (2.2 KB) - added by r-a-y 13 years ago.
Refreshed patch; also trims some trailing whitespace

Download all attachments as: .zip

Change History (10)

#1 @r-a-y
13 years ago

  • Keywords has-patch dev-feedback added; disabled_components removed

There's a check to see if multisite is enabled, if so, then the "Blog Tracking" option is displayed in the admin area.

Might make sense to remove the check in bp-core-admin.php so standard WP admins can choose to disable blog tracking.

Attached is a patch against BP v1.2.6. Anyone see any consequences with doing this?

---

If the patch isn't acceptable, you can manually add bp-blogs.php to the bp-deactivated-components option with the "bp_deactivated_components" filter (located in bp-loader.php).

Or you can use the Block Activity Stream Types plugin:
http://wordpress.org/extend/plugins/buddypress-block-activity-stream-types/

@r-a-y
13 years ago

#2 @boonebgorges
13 years ago

  • Keywords needs-refresh added; has-patch dev-feedback removed

I like the idea of removing the multisite check and letting single-WP blog admins decide whether they would like to track blog posts. This patch will need to be refreshed for the trunk. Also, the helper text ('Tracks blogs, blog posts...') will need to be reworked to account for (a) the fact that there is no more WPMU, and (b) the possibility that single-WP admins might see the option.

#3 @boonebgorges
13 years ago

Also, this patch will need to be revisited when #2943 is fixed.

@r-a-y
13 years ago

Refreshed patch; also trims some trailing whitespace

#4 @r-a-y
13 years ago

  • Keywords has-patch added; needs-refresh removed

#5 @DJPaul
13 years ago

  • Keywords dev-feedback added

What does JJJ think? This would be a big change.

#6 @DJPaul
13 years ago

  • Milestone changed from 1.3 to Future Release

Punting, because this change could potentially impact a lot of existing code around the blogs component which assumes it always runs on multisite. It would need to be carefully reviewed and the code audited.

#7 @DJPaul
11 years ago

  • Keywords has-patch removed
  • Milestone changed from Future Release to 1.8
  • Severity set to normal

Do we still want to change this, or has it already been addressed sometime in the last two years? Moving to 1.8 for review.

#8 @boonebgorges
11 years ago

  • Keywords dev-feedback removed
  • Milestone 1.8 deleted
  • Resolution set to invalid
  • Status changed from new to closed

I'm pretty sure it's no longer relevant as of 1.7, when our configuration of default components was changed. If I'm wrong about this, please reopen ticket with details.

Note: See TracTickets for help on using tickets.