Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 13 years ago

#2630 closed enhancement (fixed)

BuddyPress sign-up doesn't use banned email domains on WP

Reported by: jconti's profile j.conti Owned by:
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Core Keywords:
Cc: j.conti@…

Description

BuddyPress signup form do not filter the Banned Email Domains ("Super Admin" --> "Options" --> "Banned Email Domains").

If I disable BuddyPress, the filter woks grate.

Change History (7)

#1 @paulhastings0
14 years ago

  • Summary changed from BuddyPress singup donnot use banned email domains on WP to BuddyPress sign-up doesn't use banned email domains on WP

...just had to correct the typos...

#2 @hnla
14 years ago

It never has; it does filter on the second list though, for permitted domains.

Can we move this to 1.3 please it's too late in the day to be adding to 1.2.6 else it'll never get out the door.

#3 @j.conti
14 years ago

  • Cc j.conti@… added

Ok,

If you can't do it for 1.2.6 move it to 1.3 please.
I think it is a very important enhance for BuddyPress.

Thank you

#4 @paulhastings0
14 years ago

  • Milestone changed from 1.2.6 to 1.3
  • Priority changed from critical to normal
  • Type changed from defect to enhancement

#5 @j.conti
14 years ago

Hi,

I make some test. I'm not sure if this is legal

If you add:

if ( is_email_address_unsafe( $user_email ) )
             $errors->add('user_email',  __('You cannot use that email address to signup. We are having problems with them blocking some of our email. Please use another email provider.'));

on bp-core-signup.php just after line 352-353 http://trac.buddypress.org/browser/branches/1.2/bp-core/bp-core-signup.php#L342

if ( !is_email( $user_email ) )
                        $errors->add( 'user_email', __( 'Please check your email address.', 'buddypress' ) );

BuddyPress is filtering the banned email domains.

If this is legal, you only need to add this line and BP 1.2.6 will use "banned email domains"

I'm adding this line to all my BuddyPress installation and the splogs are finishing. :) (adding domains to banned email domains ofcourse)

#7 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3637]) Checks signup email against banned email domains list when available. Fixes #2630. Props j.conti

Note: See TracTickets for help on using tickets.