Buddypress on secondary blog, logout not working properly

[joezsweet]

hi,

not sure if this is he right place to post this kind of problems ...bear with me ..

Hi ALL,

Bte, i've installed buddypress 1.2.1 on wordpress 3.0 alfa using a secondary blog.

What happen is that an user (i.e. with test username) is logged in and it works properly.

On logout, from both admin bar and widget, what happen is that user test is logged out, but admin will keep logged in and cant be logged out.

Any hints?

Giovanni

[DJPaul]

BuddyPress 1.2 is not built and has not been tested on WP 3.0-alpha. Therefore, you will probably experience issues. Once WP 3.0 is more mature, I suspect the BP core developers will at that point start testing BuddyPress and fixing any WP-3.0 specific issues.

I see you have a forum post with regards this http://buddypress.org/forums/topic/buddypress-on-secondary-blog-logout-not-working-properly

[wpmuguru]

The scenario where this occurs is in a single WP install where the Site URL & Home URL are not the same. Patch is attached.

[boonebgorges]

Don't think there's any need to check for multisite here. $bp->root_domain should already be set to account for multisite, blog url vs site url, etc. The only concern would be BP_ENABLE_MULTIBLOG, when I assume that logout links should redirect back to the current site URL rather than $bp->root_domain.

[johnjamesjacoby]

Anymore information on this? It's on the tee to get punted to 1.3.

[boonebgorges]

If I remember correctly, an appropriate fix is just to replace site_url() on 94 with $bp->root_domain. But I am in a rush this morning so I can't test it. In any case, it's an edge case so I think it's probably OK to punt if it's holding back 1.2.6.

BTW you do know that punting doesn't happen off a tee, right :-D

[r-a-y]

Putted to 1.3 perhaps? ;)

[johnjamesjacoby]

Gooooooooooooaaaaaaaaaaaaaaal! :)

[DJPaul]

This issue needs to be verified and the patch tested on the current trunk

[r-a-y]

I tried to duplicate what wpmuguru mentioned a few comments above where Wordpress is installed in a subdirectory and could not reproduce the problem.

Re: the initial bug report - Does Giovanni mean if he logs out from the frontend, he is still logged in at /wp-admin/? If that is the case, I do not experience this issue on a BP 1.2.6 install where BuddyPress is installed on a secondary blog.

Could use some confirmation from other users.

[DJPaul]

Is this related to #3052? We need to audit site_url vs home_url use.

[r-a-y]

I can confirm the error now by following these instructions:
​http://codex.wordpress.org/Giving_WordPress_Its_Own_Directory

home_url() or $bp->root_domain [bp_core_get_root_domain()] should fix all instances. No need to check bp_core_is_multisite() as per wpmuguru's patch.

bp_core_get_root_domain() itself uses get_home_url().

[johnjamesjacoby]

I started to audit the site_url() and home_url() usage a few weeks ago, since we used site_url in a ton of places that was causing grief with exactly what r-a-y mentioned above.

[turnheim]

You have the problem with site_url versus home_url als in the default theme all over the place.
Would be nice to get this also corrected.
Thanks

[r-a-y]

@turnheim - The problem has been noted.

Here's a patch to fix this specific ticket for BP 1.3.

[DJPaul]

[4142] Use home_url instead of site_url in buddybar my account logout link. Props r-a-y, fixes #2109

Sorry for forgetting props on the commit message