Skip to:

Opened 14 years ago

Closed 13 years ago

Last modified 8 years ago

#2016 closed defect (bug) (fixed)

activity comment markup & ajax loading

Reported by: mikepratt's profile mikepratt Owned by: djpaul's profile DJPaul
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Templates Keywords:


BP 1.2 final
WPMU 2.9.1

This issue presents itself when you hook into bp_activity_comments in order to add/modify markup for the activity comment function bp_activity_recurse_comments. I needed to to add some span elements to allow me to make use of sprites for acomment backgrounds.

When a new comment is made to an activity via ajax on a child theme of bp-default, the markup for that comment is initially presented via ajax.php in bp_dtheme_new_activity_comment() at line 184. Until page refresh, this is the markup for that new comment.

The solution will be to either mod both bp_dtheme_new_activity_comment() and bp_activity_comments in order to insert identical html. I see the TODO to remove the markup from bp_activity_comments and hopefully it will be consolidated into one call. For now, it causes a styling problem w/o all the hooks.

I realize this may not be a 'bug' so much as a code design issue but may be important for those needed to mod the comment markup beyond what is provided.

Perhaps can be called from bp_dtheme_new_activity_comment() in ajax.php?

Change History (6)

#1 @cnorris23
13 years ago

  • Component set to Theme
  • Keywords reporter-feedback added; comment ajax removed

Is this still an issue? From a cursory review of the code, it appears to be. This will all likely change when 1.4 hits, but for now it looks like bp_dtheme_new_activity_comment() could use some of the same filters as bp_activity_comments().

#2 @DJPaul
13 years ago

  • Keywords reporter-feedback removed
  • Owner set to DJPaul
  • Status changed from new to assigned

This is still an issue, and I'm working on a patch

#3 @djpaul
13 years ago

(In [4255]) When posting to activity stream, make the AJAX-returned markup identical to the rest of the activity stream items. See #2016

#4 @DJPaul
13 years ago

  • Milestone changed from 1.3 to Future Release
  • Priority changed from major to normal

The above commit makes the generated HTML output the same. The filters still need to be added, which is probably best done by consolidating these two functions into one, as Mike Pratt suggested.

#5 @DJPaul
13 years ago

  • Milestone changed from Future Release to 1.5
  • Resolution set to fixed
  • Severity set to normal
  • Status changed from assigned to closed

This was fixed in r4668

#6 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.