Duplicate Activation Email Sent When Using Invite Registration Feature

[vapvarun]

When using the invite registration feature, a member invites a user to join the website via email. The invited user receives an email with the subject line "user has invited you to join [sitename]." Upon clicking the link in the email to complete their registration, their account is activated immediately. However, once this process is complete, the invited user also receives a separate activation email containing a link that, when clicked, indicates that their account is already active. This duplicate activation email should not be sent.

This issue confuses new users who receive duplicate activation emails after activating their accounts. Preventing the duplicate email will streamline the user registration experience.

[vapvarun]

invite email already contain user activation flow

[vapvarun]

​https://www.loom.com/share/99c14f6559644fbda671924a0fda56cd

[dcavins]

Using vanilla BP 12.5.1 I get the following workflow:
Existing user invites new user to site.
New user gets email with "accept your invitation" link.
Following link takes user to registration form.
User fills out registration form.
Upon completion, new user sees the Account Activated! screen.
Site admin receives "New User Registration" email.
New user receives "Welcome!" email.

Using BP Beta Tester plugin to use 14-b2
Flow is the same as 12.5.1.

This is the expected workflow, as far as I understand it to be. Varun, do you have some other plugins activated? Are you using single site or network setup?

Edit: It was fun to watch your test video, I use the exact same Local + Mailpit setup for testing and it's awesome. I'll attach a photo of the Mailpit inbox after I invited a new user in 12.5.1 and 14.

[dcavins]

Mailpit inbox after two invitations, one in BP 12.5.1 and one in BP 14-b2

[dcavins]

Resolves duplicate email when accepting invite while requests are active.

[dcavins]

So the primary issue is that invitations are not really accepted until the bp_core_signup_user hook, and that happens after apply_filters( 'bp_core_signup_send_activation_key'... in bp_core_signup_user().

However, there are some interactions that still need to be thought through. For instance, if you are allowing membership requests and invitations, then, if a request has been made, extending an invitation to that same user should accept the request, which is not currently happening. When both are active, we need to check the following cases:

• invitation only path
• request only path
• invitation followed by request (this should ignore the invitation if the user simply comes to * the request membership form without following the invitation link)
• request followed by invitation (this should result in the user being activated)

I can look at the last issue on Friday, but I don't have any more time today. We've got to celebrate Independence Day here in the US. :)

[imath]

Thanks a lot for work on the issue and for your patch @dcavins 😍, happy Independence day 🗽.

I think we can wait for 15.0 for the site memberships/invitations improvements. Most important to me was to fix the duplicate email.

@vapvarun can you check it's also fixing the issue for you? I'll commit @dcavins 's patch once you confirmed.

[vapvarun]

Thanks @dcavins patch is working perfectly, Happy Independence Day 🗽.
​https://prnt.sc/-81ir2UDC0xt ( no extra email for account activation after the invitation is accepted )
​https://www.loom.com/share/e131c2882b9c49a6b1542dda1aed4405

[imath]

In 13945:

Site invitations: avoid duplicate activation emails

Props dcavins, vapvarun, emaralive

Fixes #9206

[dcavins]

Thanks for testing!