Move some BP_User_Query::populate_extras() properties to hooks

[r-a-y]

In BP_User_Query::populate_extras(), we hook the XProfile component and Friends component to add in extra data to the user query results. See bp_xprofile_filter_user_query_populate_extras() and bp_friends_filter_user_query_populate_extras().

However, we hardcode the last activity timestamp, total friend count, last activity update and meta_key/meta_value (if passed) to the user query results. What if we do not want to query and return these items to the user results?

This patch moves the hardcoded items to hooks, so it is possible for developers to remove some of these fetched properties from the BP user query.

[espellcaste]

A nice addition.

Only two suggestions comes to mind:

Add @global wpdb $wpdb WordPress database object. to the new bp_members_filter_user_query_populate_extras_meta function.

And change the references from add_filter to add_action since you are modifying the user query but not returning anything. This "issue" is true to the examples you shared too. ​See.

It's true that it works as is but it is semantically incorrect.

[espellcaste]

I'm bumping this ticket to the next version only because we plan to release BP 14.0 in 5 days. But @imath can decide here if we can add it now. Seems low risk to me.

[imath]

Hi @r-a-y & @espellcaste

Thanks a lot for your contributions, I agree with @espellcaste let’s take some more time to work on it during next release 👍

[espellcaste]

@r-a-y I can make the changes, if you want. What do you think?

[r-a-y]

Replying to espellcaste:

@r-a-y I can make the changes, if you want. What do you think?

Feel free to make the changes, espellcaste!

[espellcaste]

In 13994:

Move some BP_User_Query::populate_extras() properties to custom action hooks.

The action of populating class properties were moved from the populate_extras method into action hooks, allowing developers to remove any of them, if needed.

Props r-a-y and imath.

Fixes #9205