Skip to:
Content

BuddyPress.org

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#9164 closed enhancement (fixed)

Docblock improvements for 14.0

Reported by: espellcaste's profile espellcaste Owned by: espellcaste's profile espellcaste
Milestone: 14.0.0 Priority: low
Severity: trivial Version:
Component: Core Keywords: has-patch
Cc:

Description (last modified by espellcaste)

  • Add DocBlocks where missing
  • Clarify param/return types where applicable
  • Add missing @since versions

Inspired by WordPress Core and something we will have from now on. See #60699 No more seeing wrong docblocks and not changing them because there is no related ticket.

Change History (26)

#1 @espellcaste
5 months ago

  • Component changed from Documentation to Core
  • Priority changed from normal to low
  • Severity changed from normal to trivial

#2 @espellcaste
5 months ago

  • Description modified (diff)

This ticket was mentioned in PR #302 on buddypress/buddypress by renatonascalves.


5 months ago
#3

  • Keywords has-patch added

#5 @espellcaste
5 months ago

In 13879:

WPCS: miscellaneous fixes for the src/bp-core/admin/bp-core-admin-functions.php template.

See #7224
See #9164

#6 @espellcaste
5 months ago

In 13880:

WPCS: miscellaneous fixes for the src/bp-core/admin/bp-core-admin-actions.php template.

See #7228
See #9164

#7 @espellcaste
5 months ago

In 13881:

WPCS: miscellaneous fixes for the src/bp-core/admin/bp-core-admin-components.php template.

See #7228 and #9164

#8 @espellcaste
5 months ago

In 13882:

PHPDoc: Update incorrect instances of void.

Closes https://github.com/buddypress/buddypress/pull/302
See #9164

#9 @espellcaste
5 months ago

In 13883:

WPCS: miscellaneous fixes for some of the files of the core component.

Closes https://github.com/buddypress/buddypress/pull/304
See #9164 and #7228

#10 @espellcaste
5 months ago

In 13886:

WPCS: Part II: miscellaneous fixes for some of the files of the core component.

Follow-up to 13883.

See #9164 and #7228

#11 @espellcaste
5 months ago

In 13887:

WPCS: Part III: miscellaneous fixes for some of the files of the core component.

Follow-up to [13883] and [13886]

See #9164 and #7228

#12 @espellcaste
5 months ago

In 13888:

WPCS: Part IV: miscellaneous fixes for some of the files of the core component.

Follow-up to [13883], [13886], and [13887]

See #9164 and #7228

#13 @espellcaste
5 months ago

In 13889:

WPCS: Fix the method signatures for allow_invitation and allow_request.

See #9164 and #7228

#14 @espellcaste
5 months ago

In 13890:

PHPDoc: remove superfluous comments from boolean returns.

See #9164

#15 @espellcaste
5 months ago

In 13891:

WPCS: Part V: miscellaneous fixes for some of the files of the core component.

Follow-up to [13883], [13886], [13887], and [13888]

See #9164 and #7228

#16 @espellcaste
5 months ago

In 13892:

WPCS: Part VI: miscellaneous fixes for some of the files of the core component.

Follow-up to [13883], [13886], [13887], [13888], and [13891]

See #9164 and #7228

#17 @espellcaste
5 months ago

In 13893:

WPCS: Part VII: miscellaneous fixes for some of the files of the core component.

Follow-up to [13883], [13886], [13887], [13888], [13891], and [13892]

See #9164 and #7228

#19 @espellcaste
5 months ago

In 13896:

PHPDoc: Correct placement of @since tags.

The @since tag should added before @global, @param, and @return.

Props shailu25
Closes https://github.com/buddypress/buddypress/pull/310
See #9164
Fixes #9168

#21 @espellcaste
5 months ago

In 13900:

WPCS: Part VIII: miscellaneous fixes for some of the files of the core component.

Follow-up to [13883], [13886], [13887], [13888], [13891], [13892], [13893]

See #9164 and #7228

#22 @espellcaste
5 months ago

In 13901:

WPCS: Part IX: miscellaneous fixes for some of the files of the core component.

Follow-up to [13883], [13886], [13887], [13888], [13891], [13892], [13893] and [13900]

See #9164 and #7228

#23 @espellcaste
5 months ago

In 13903:

WPCS: Part X: miscellaneous fixes for some of the files of the core component.

Follow-up to [13901]

See #9164 and #7228

#24 @espellcaste
5 months ago

In 13904:

WPCS: Part XI: miscellaneous fixes for some of the files of the core component.

Follow-up to [13903]

See #9164 and #7228

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.


5 months ago

#26 @espellcaste
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Closing for now, any new updates like this can happen in trunk for 15.0. See #9173

Last edited 5 months ago by espellcaste (previous) (diff)
Note: See TracTickets for help on using tickets.