Skip to:
Content

BuddyPress.org

Opened 3 months ago

Closed 3 months ago

#9150 closed defect (bug) (fixed)

filter `bp_get_group_description_excerpt` - no argument passing

Reported by: pawelhalickiotgs's profile pawelhalickiotgs Owned by: imath's profile imath
Milestone: 12.5.0 Priority: normal
Severity: normal Version: 12.4.1
Component: Groups Keywords:
Cc:

Description

Hello, my name is Paweł Halicki, I work at https://onthegosystems.com/

We have a plugin prepared for compatibility with BuddyPress - https://wpml.org/plugin/buddypress/

We have been using the bp_get_group_description_excerpt filter for years, and since version 12.4.1, the second 'group' argument has stopped being passed in some places

https://github.com/buddypress/buddypress/blame/master/src/bp-templates/bp-nouveau/includes/groups/template-tags.php#L1373

We use the described interface

https://github.com/buddypress/buddypress/blob/master/src/bp-groups/bp-groups-template.php#L1593

We would really like it to be followed everywhere - thanks to this we could ensure the proper functioning of integration

Regards

Change History (4)

#1 @imath
3 months ago

  • Component changed from Core to Groups
  • Milestone changed from Awaiting Review to 12.5.0
  • Version set to 12.4.1

Hi @pawelhalickiotgs

Thanks a lot for your report. I’ll look at it asap.

#2 @pawelhalickiotgs
3 months ago

thanks for the quick reaction,
We are waiting for news

Regards

#3 @imath
3 months ago

In 13854:

BP Nouveau: add missing $group parameter to the group excerpt filter

In [13820], escaping the bp_nouveau_group_description_excerpt() function output was made using the bp_get_group_description_excerpt filter. This move was incomplete as this filter accepts 2 parameters (the shrinked description and the Group object) and only the first one was provided.

This change adds the missing parameter and also improves the Nouveau template pack consistency.

Props pawelhalickiotgs

See #9150 (trunk)

#4 @imath
3 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13855:

BP Nouveau: add missing $group parameter to the group excerpt filter

In [13820], escaping the bp_nouveau_group_description_excerpt() function output was made using the bp_get_group_description_excerpt filter. This move was incomplete as this filter accepts 2 parameters (the shrinked description and the Group object) and only the first one was provided.

This change adds the missing parameter and also improves the Nouveau template pack consistency.

Props pawelhalickiotgs

Fixes #9150 (branch 12.0)

Note: See TracTickets for help on using tickets.