Skip to:
Content

BuddyPress.org

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#9149 closed enhancement (fixed)

Add link to GH docs for the bp-signups (a.k.a. Managing Signups) page/screen help tab

Reported by: emaralive's profile emaralive Owned by: imath's profile imath
Milestone: 14.0.0 Priority: normal
Severity: normal Version: 12.4.1
Component: Administration Keywords: has-screenshots has-patch dev-feedback
Cc:

Description

The link to be added is:

https://github.com/buddypress/buddypress/blob/master/docs/user/administration/users/signups.md#manage-pending-user-accounts

This is represented by inserting the following into BP_Members_Admin::signups_admin_load(), of which the method is found around Line 1808 of class-bp-members-admin.php:

$manage_pending_ua = sprintf(
        '<a href="%1$s">%2$s</a>',
         esc_url( 'https://github.com/buddypress/buddypress/blob/master/docs/user/administration/users/signups.md#manage-pending-user-accounts' ),
         esc_html__( 'Managing Pending User Accounts', 'buddypress' )
);

Additionally, the plan is also to replace the way the link to the Support Forum is currently represented with the following:

$this->bp_forum = sprintf(
        '<a href="%1$s">%2$s</a>',
        esc_url( 'https://buddypress.org/support/' ),
        esc_html__( 'Support Forums', 'buddypress' )
);

The reason for the $bp_forum property is because there are 2 other class methods (BP_Members_Admin::members_invitations_admin_load() and BP_Members_Admin::user_admin_load()) that contain links to the Support Forum and can be replaced with the $bp_forum property. I did not replace those links because I was only tasked to add a link to the appropriate GH document, of which placement is within the BP_Members_Admin::signups_admin_load() method.

Having stated the above, the screenshots represent the help tab for the bp-signup page/screen before (screenshot-win10-me-2024.05.05-08_50_45.png) and after (screenshot-win10-me-2024.05.05-09_00_43.png). The patch represents the initial proposed change.

Attachments (4)

screenshot-win10-me-2024.05.05-08_50_45.png (157.1 KB) - added by emaralive 2 months ago.
screenshot-win10-me-2024.05.05-08_50_45.png
screenshot-win10-me-2024.05.05-09_00_43.png (145.3 KB) - added by emaralive 2 months ago.
screenshot-win10-me-2024.05.05-09_00_43.png
9149.01.patch (1.7 KB) - added by emaralive 2 months ago.
Initial patch
9149.02.patch (1.7 KB) - added by emaralive 2 months ago.
Replaces 9149.01.patch

Download all attachments as: .zip

Change History (8)

@emaralive
2 months ago

screenshot-win10-me-2024.05.05-08_50_45.png

@emaralive
2 months ago

screenshot-win10-me-2024.05.05-09_00_43.png

@emaralive
2 months ago

Initial patch

#1 @imath
2 months ago

Hi @emaralive

Thanks a lot for you work on the ticket & patch. Patch looks good 👍.

I simply believe this kind of change can be done in 14.0.0 as this is not something introduced in 12.0.0 we need to fix in a 12.x minor release.

#2 @emaralive
2 months ago

  • Milestone changed from 12.5.0 to 14.0.0

@imath sounds good, I'll change the milestone to 14.0 and upload a new patch (the .01 patch has a DocBlock reference to 12.5.0) with a DocBlock reference to 14.0.0.

@emaralive
2 months ago

Replaces 9149.01.patch

#3 @imath
2 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13856:

Add a documentation link into the BP Signups Admin Screen help tab

Props emaralive

Fixes #9149

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


2 months ago

Note: See TracTickets for help on using tickets.