#9149 closed enhancement (fixed)
Add link to GH docs for the bp-signups (a.k.a. Managing Signups) page/screen help tab
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 14.0.0 | Priority: | normal |
Severity: | normal | Version: | 12.4.1 |
Component: | Administration | Keywords: | has-screenshots has-patch dev-feedback |
Cc: |
Description
The link to be added is:
https://github.com/buddypress/buddypress/blob/master/docs/user/administration/users/signups.md#manage-pending-user-accounts
This is represented by inserting the following into BP_Members_Admin::signups_admin_load()
, of which the method is found around Line 1808 of class-bp-members-admin.php:
$manage_pending_ua = sprintf( '<a href="%1$s">%2$s</a>', esc_url( 'https://github.com/buddypress/buddypress/blob/master/docs/user/administration/users/signups.md#manage-pending-user-accounts' ), esc_html__( 'Managing Pending User Accounts', 'buddypress' ) );
Additionally, the plan is also to replace the way the link to the Support Forum is currently represented with the following:
$this->bp_forum = sprintf( '<a href="%1$s">%2$s</a>', esc_url( 'https://buddypress.org/support/' ), esc_html__( 'Support Forums', 'buddypress' ) );
The reason for the $bp_forum
property is because there are 2 other class methods (BP_Members_Admin::members_invitations_admin_load()
and BP_Members_Admin::user_admin_load()
) that contain links to the Support Forum and can be replaced with the $bp_forum
property. I did not replace those links because I was only tasked to add a link to the appropriate GH document, of which placement is within the BP_Members_Admin::signups_admin_load()
method.
Having stated the above, the screenshots represent the help tab for the bp-signup page/screen before (screenshot-win10-me-2024.05.05-08_50_45.png) and after (screenshot-win10-me-2024.05.05-09_00_43.png). The patch represents the initial proposed change.
Attachments (4)
Change History (8)
#1
@
9 months ago
Hi @emaralive
Thanks a lot for you work on the ticket & patch. Patch looks good 👍.
I simply believe this kind of change can be done in 14.0.0 as this is not something introduced in 12.0.0 we need to fix in a 12.x minor release.
#2
@
9 months ago
- Milestone changed from 12.5.0 to 14.0.0
@imath sounds good, I'll change the milestone to 14.0 and upload a new patch (the .01 patch has a DocBlock reference to 12.5.0) with a DocBlock reference to 14.0.0.
#3
@
9 months ago
- Owner set to imath
- Resolution set to fixed
- Status changed from new to closed
In 13856:
screenshot-win10-me-2024.05.05-08_50_45.png