Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#9125 closed enhancement (fixed)

ctype_digit(): Argument of type int will be interpreted as string in the future

Reported by: shawfactor Owned by: espellcaste
Priority: low Milestone: 14.0.0
Component: Core Version: 12.3.0
Severity: trivial Keywords: has-patch
Cc:

Description

Seems this was not fixed in #8649

buddypress/bp-core/classes/class-bp-media-extractor.php line 784

is triggered by:

wp-json/wp/v2/posts/77494?_locale=user

I can't reopen te previous issue hence the new one.

Change History (3)

#1 @espellcaste
2 years ago

  • Milestone Awaiting Review → 14.0.0
  • Owner set to espellcaste
  • Status new → assigned
  • Type defect (bug) → enhancement

Thanks! That's an easy fix.

This ticket was mentioned in ​PR #265 on ​buddypress/buddypress by ​renatonascalves.
2 years ago #2

  • Keywords has-patch added

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9125

I noticed that some of those values are already integers. But to avoid messing anything up, I opted for a more conservative approach, fixing only the following "issue":

ctype_digit(): Argument of type int will be interpreted as string in the future

Related: ​https://www.php.net/manual/en/function.ctype-digit.php#refsect1-function.ctype-digit-parameters

#3 @espellcaste
2 years ago

  • Resolution → fixed
  • Status assigned → closed

In 13793:

Cast values used in the ctype_digit function to a string.

Argument of type int will be interpreted as string in the future.

Closes ​https://github.com/buddypress/buddypress/pull/265
See #8649
Fixes #9125

Note: See TracTickets for help on using tickets.