Skip to:
Content

BuddyPress.org

Opened 9 months ago

Closed 8 months ago

Last modified 6 months ago

#9125 closed enhancement (fixed)

ctype_digit(): Argument of type int will be interpreted as string in the future

Reported by: shawfactor's profile shawfactor Owned by: espellcaste's profile espellcaste
Milestone: 14.0.0 Priority: low
Severity: trivial Version: 12.3.0
Component: Core Keywords: has-patch
Cc:

Description

Seems this was not fixed in #8649

buddypress/bp-core/classes/class-bp-media-extractor.php line 784

is triggered by:

wp-json/wp/v2/posts/77494?_locale=user

I can't reopen te previous issue hence the new one.

Change History (3)

#1 @espellcaste
9 months ago

  • Milestone changed from Awaiting Review to 14.0.0
  • Owner set to espellcaste
  • Status changed from new to assigned
  • Type changed from defect (bug) to enhancement

Thanks! That's an easy fix.

This ticket was mentioned in ​PR #265 on ​buddypress/buddypress by ​renatonascalves.
8 months ago #2

  • Keywords has-patch added

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9125

I noticed that some of those values are already integers. But to avoid messing anything up, I opted for a more conservative approach, fixing only the following "issue":

ctype_digit(): Argument of type int will be interpreted as string in the future

Related: ​https://www.php.net/manual/en/function.ctype-digit.php#refsect1-function.ctype-digit-parameters

#3 @espellcaste
8 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13793:

Cast values used in the ctype_digit function to a string.

Argument of type int will be interpreted as string in the future.

Closes ​https://github.com/buddypress/buddypress/pull/265
See #8649
Fixes #9125

Note: See TracTickets for help on using tickets.