Changeset 13793

Timestamp:

04/12/2024 01:28:59 PM (8 months ago)

Author:

espellcaste

Message:

Cast values used in the ctype_digit function to a string.

Argument of type int will be interpreted as string in the future.

Closes ​https://github.com/buddypress/buddypress/pull/265
See #8649
Fixes #9125

Location:

trunk/src/bp-core

Files:

• bp-core-attachments.php (modified) (1 diff)
• classes/class-bp-media-extractor.php (modified) (2 diffs)

trunk/src/bp-core/bp-core-attachments.php

@@ -1574 +1574 @@
     }
 
-    if ( empty( $_POST['object'] ) || empty( $_POST['item_id'] ) || ( ! ctype_digit( $_POST['item_id'] ) && ! is_int( $_POST['item_id'] ) ) ) {
+    if ( empty( $_POST['object'] ) || empty( $_POST['item_id'] ) || ( ! ctype_digit( (string) $_POST['item_id'] ) && ! is_int( $_POST['item_id'] ) ) ) {
         wp_send_json_error();
     }

trunk/src/bp-core/classes/class-bp-media-extractor.php

@@ -778 +778 @@
 
                 // A width was specified but not a height, so calculate it assuming a 4:3 ratio.
-                if ( ! isset( $extra_args['height'] ) && ctype_digit( $extra_args['width'] ) ) {
+                if ( ! isset( $extra_args['height'] ) && ctype_digit( (string) $extra_args['width'] ) ) {
                     $extra_args['height'] = round( ( $extra_args['width'] / 4 ) * 3 );
                 }
 
-                if ( ctype_digit( $extra_args['width'] ) ) {
+                if ( ctype_digit( (string) $extra_args['width'] ) ) {
                     $image_size = array( $extra_args['width'], $extra_args['height'] );
                 } else {
@@ -877 +877 @@
             // Validate the size of the images requested.
             if ( isset( $extra_args['width'] ) ) {
-                if ( ! isset( $extra_args['height'] ) && ctype_digit( $extra_args['width'] ) ) {
+                if ( ! isset( $extra_args['height'] ) && ctype_digit( (string) $extra_args['width'] ) ) {
                     // A width was specified but not a height, so calculate it assuming a 4:3 ratio.
                     $extra_args['height'] = round( ( $extra_args['width'] / 4 ) * 3 );
                 }
 
-                if ( ctype_digit( $extra_args['width'] ) ) {
+                if ( ctype_digit( (string) $extra_args['width'] ) ) {
                     $image_size = array( $extra_args['width'], $extra_args['height'] );
                 } else {