The Activity "Post Comment" setting should be disabled if WP Post's support for BP Activities is not set

[imath]

Working on #9004 I noticed we were displaying the option to activate/deactivate comments about WP Post's generated BP Activities regardless of WP Post's support for BP Activities.

As this support is automatically added if the Site Tracking component is active, I believe we should review this setting's UI to improve user experience & explain this fact.

I'll suggest a PR in a few minutes.

Uses a Post type's support check about BP Activities to disable the "Post Comments" option and include a description about why it's disabled and how to have it enabled.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9016

I'm not sure what the sentence "WordPress Post\'s support for BuddyPress activities is not active" means. Can you explain a little more about that so I can help with the language? I see this in the commit post_type_supports( 'post', 'buddypress-activity' ) but don't know what that is doing, honestly. :)

Sure, if the WordPress post's post type supports BP Activities then each time a post or a comment will be published or submitted, then an activity will be generated. By default it's not possible to add comments to these activities, these option allows it as it's also generating a WordPress comment when an activity about a post or a comment is commented.

Ah, OK. How about something simple, like "Activate the BuddyPress Site Tracking component in order to enable this feature."

I agree! Simple is beautiful 👍

imath
​https://imathi.eu

De : David Cavins *@*.*>
Envoyé : Saturday, November 4, 2023 3:24:03 PM
À : buddypress/buddypress *@*.*>
Cc : imath *@*.*>; Author *@*.*>
Objet : Re: [buddypress/buddypress] Improve Post Comments settings UI (PR #185)

Ah, OK. How about something simple, like "Activate the BuddyPress Site Tracking component in order to enable this feature."

—
Reply to this email directly, view it on GitHub<​https://github.com/buddypress/buddypress/pull/185#issuecomment-1793456835>, or unsubscribe<​https://github.com/notifications/unsubscribe-auth/AAN74HCF5EPWNGFKKTD3FPTYCZFYHAVCNFSM6AAAAAA65PIYHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGQ2TMOBTGU>.
You are receiving this because you authored the thread.Message ID: *@*.*>

[imath]

In 13633:

Disable the Activity the "Post Comments" option by default

The value of this option only has an effect when the WordPress post's post type supports BuddyPress activities. BuddyPress adds this support only when the Site Tracking component is active (which is not the case, by default, for new installs).

Props dcavins

Fixes #9016
Closes ​https://github.com/buddypress/buddypress/pull/185