Members listing page shows wrong active members counter

[Diabolique]

Hello,

When you are on the mambers listing page - (​https://domainname.com/members/) there is a counter of active members. When you enter the page it shows correct number but instantly some javascript action switches it to the number of users which are actually on the page, for example if there is 20 users per page then it shows 20 number, if there are 5 members per page then it shows 5 number instead of showing total count.

[dontdream]

For completeness, this happens with the Nouveau template pack, not with Legacy.

[imath]

Thanks for your report @Diabolique

I'll look at it asap. I'm a bit surprised it doesn't take the total active members count, I'm the one who added the JavaScript 😅 see #8101

[imath]

I confirm the issue, working on a fix.

In ​[13136] I've haven't used the right property to get the total member count. The member_count property in informing about the number of displayed members, the total_member_count is the right property to use.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9001

[imath]

In 13593:

BP Nouveau: use the right count for the Members dynamic directory tab

In [13136] the $member_count property was wrongly used to inform about the total member count. $member_count is informing about the number of displayed members. The $total_member_count property is the right one to use.

Props Diabolique

Fixes #9001
Closes ​https://github.com/buddypress/buddypress/pull/173