'All members' is filtering by 'last_activity' which produces wrong count value

[ketan_chawda]

Step -1) Visit : your-wp-url/members
Step-2) All Members label is misleading, it is filtering by Last Active.
Suggestion : All members count can be legit if default filter is Alphabetical instead of Last Active

Possible Solution :
Related hooks(actions and filters) : add_filter('bp_get_total_member_count', 'custom-function');
add_action('bp_nouveau_get_members_filters', 'custom-function');

[ketan_chawda]

Members filters

[imath]

Hi,

Thanks for your feedback, I must concede "All" is misleading in this case. And this confusion is often made by end users. I agree we need to improve this. I'm going to work on it during 10.0.0.

[imath]

In ​8101.patch I suggest to update the first nav label according to the current filter. If it's Last active, then we get:

If it's Newest registered, then we get:

Finally when it's alphabetical we get all members (in my example, there's a user who never logged in) :

Would this stop confusing users?

PS: I'm focusing on the BP Nouveau template pack.

[imath]

In 13136:

BP Nouveau: improve the Members' directory primary nav's text

The Nouveau template pack will from now on update the Members's directory primary nav's text according to the members displayed list. The 'All Members' text will only be used when filtering this list alphabetically. When using the default filter (last active), this text will now be 'Active Members'. Finally, when filtering the list using the "Newest registered" option, this text will now be 'Newest Members'.

We believe this improvement can avoid the confusion we often make about this nav's count information. To be sure to get the 'All Members' count right, you need to sort the list alphabetically.

Props ketan_chawda

Fixes #8101