Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 5 weeks ago

#8101 closed defect (bug) (fixed)

'All members' is filtering by 'last_activity' which produces wrong count value

Reported by: ketan_chawda Owned by: imath
Milestone: 10.0.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: has-patch
Cc: chawda.ketan.a@…

Description

Step -1) Visit : your-wp-url/members
Step-2) All Members label is misleading, it is filtering by Last Active.
Suggestion : All members count can be legit if default filter is Alphabetical instead of Last Active

Possible Solution :
Related hooks(actions and filters) : add_filter('bp_get_total_member_count', 'custom-function');
add_action('bp_nouveau_get_members_filters', 'custom-function');

Attachments (2)

buddpress-4.0.1-bug-reporting.jpg (128.1 KB) - added by ketan_chawda 3 years ago.
Members filters
8101.patch (5.6 KB) - added by imath 2 months ago.

Download all attachments as: .zip

Change History (5)

@ketan_chawda
3 years ago

Members filters

#1 @imath
3 months ago

  • Keywords needs-patch added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 10.0.0
  • Owner set to imath
  • Status changed from new to assigned

Hi,

Thanks for your feedback, I must concede "All" is misleading in this case. And this confusion is often made by end users. I agree we need to improve this. I'm going to work on it during 10.0.0.

@imath
2 months ago

#2 @imath
2 months ago

  • Component changed from Members to Templates
  • Keywords has-patch added; needs-patch removed
  • Version changed from 4.1.0 to 3.0.0

In 8101.patch I suggest to update the first nav label according to the current filter. If it's Last active, then we get:

https://cldup.com/zN_MTCpAfn.png

If it's Newest registered, then we get:

https://cldup.com/Ud5UbEolbd.png

Finally when it's alphabetical we get all members (in my example, there's a user who never logged in) :

https://cldup.com/f4J1E2iaU6.png

Would this stop confusing users?

PS: I'm focusing on the BP Nouveau template pack.

#3 @imath
5 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13136:

BP Nouveau: improve the Members' directory primary nav's text

The Nouveau template pack will from now on update the Members's directory primary nav's text according to the members displayed list. The 'All Members' text will only be used when filtering this list alphabetically. When using the default filter (last active), this text will now be 'Active Members'. Finally, when filtering the list using the "Newest registered" option, this text will now be 'Newest Members'.

We believe this improvement can avoid the confusion we often make about this nav's count information. To be sure to get the 'All Members' count right, you need to sort the list alphabetically.

Props ketan_chawda

Fixes #8101

Note: See TracTickets for help on using tickets.