Skip to:
Content

BuddyPress.org

Opened 8 months ago

Closed 8 months ago

#8979 closed enhancement (fixed)

Register & Activate are not directories v12.0.0-beta1

Reported by: vapvarun's profile vapvarun Owned by: imath's profile imath
Milestone: 12.0.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords: 2nd-opinion has-patch
Cc:

Description

Display options for registering and activating are shown as Directory Title and Directory Slug. Their names can be used as is to represent them. These pages are not a directory, unlike activity, groups, and members.

Register Title
Register Slug

https://prnt.sc/Qx06Arn5bzT8

Change History (7)

#1 @imath
8 months ago

  • Keywords 2nd-opinion added
  • Milestone changed from Awaiting Review to 12.0.0
  • Type changed from defect (bug) to enhancement

Hi @vapvarun

Technically they are directory pages in the sense BuddyPress has always created WordPress Pages for them: it's easier this way to customize slug and title I believe.

In BP 11.0, you'll see you can use the activate or register page in menus:

https://cldup.com/EMD9EllA2o.png

Still in BP 11.0, you'll find them into the list of BuddyPress pages as well:

https://cldup.com/eb2NZNaw0H.png

To preserve the pre-12.0 possibility to customize these specific pages slugs and titles, we absolutely need to include them into the URLs settings tab.

If it's a semantic issue, we can always rename the corresponding Accordion panels like "Specific pages". But again, technically they are treated like directory pages 😅

#2 @vapvarun
8 months ago

My concern was not with the special pages, but rather the labels we have assigned to them.
We can simply label options for them as

Register Title
Register Slug

Activate Title
Activate Title

We can also choose to keep it straightforward, such as:
Title
Slug

Using the prefix "Directory" could cause confusion.

#3 @imath
8 months ago

Ok that's a semantic issue then, I'm fine with this idea as it will improve user experience compare to the pre-12.0 situation.

I also believe we should consider removing possibility to include the Activate page inside WordPress menus (it could easily bee achieved using a specific custom post_status for this page.

Last edited 8 months ago by imath (previous) (diff)

#4 @imath
8 months ago

  • Keywords needs-patch added

This ticket was mentioned in PR #154 on buddypress/buddypress by @imath.


8 months ago
#5

  • Keywords has-patch added; needs-patch removed

Use "Page" instead of "Directory" for the activate & register pages

Trac ticket: https://buddypress.trac.wordpress.org/ticket/8979

#6 @imath
8 months ago

  • Component changed from Settings to Administration

#7 @imath
8 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13555:

Administration: improve URLs settings tab specific page sections

Differentiate specific pages (activate/register) from directories using the "Page" labelling in corresponding sections.

Props vapvarun

Fixes #8979
Closes https://github.com/buddypress/buddypress/pull/154

Note: See TracTickets for help on using tickets.