Typo in URL prevents accepting group memberships

[coffee2code]

An issue has cropped up recently with group admins on profiles.wordpress.org not being able to approve group memberships. After clicking the 'Accept' link next to the membership request (on the group's frontend 'Manage' tab), they encounter a 404.

After investigation, I discovered that [13446] changed how group links were generated. It looks as though the 'Accept' link generated via bp_get_group_request_accept_link() has a typo introduced during this rewrite, missing the ending 's'. When the request is sent against the pluralized path of 'membership-requests' the action completes successfully. The associated 'Reject' link generated via bp_get_group_request_reject_link() uses the pluralized form of 'membership-requests'.

Patch attached.

[coffee2code]

Patch mentioned in ticket.

[imath]

Hi @coffee2code

Thanks a lot for your feedback and patch 😍. I will commit it asap 👌

[imath]

In 13548:

Groups: fix a typo in the group requests management "Accept" link

• An "s" was missing at the end of the Group management Action in bp_get_group_request_accept_link().
• This commit also avoids a notice error about an undefined $group variable by replacing this variable by groups_get_current_group().

Props coffee2code

Fixes #8974