Skip to:
Content

BuddyPress.org

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#8975 closed defect (bug) (fixed)

Single message thread is not loading message details v12.0.0-beta1

Reported by: vapvarun's profile vapvarun Owned by: imath's profile imath
Milestone: 12.0.0 Priority: normal
Severity: normal Version:
Component: Messages Keywords: has-patch
Cc:

Description

Single Thread is not loading the message details.

https://prnt.sc/nAHDr86_M7DF

action=messages_get_thread_messages is getting the response value.

Env: Standard WP Docker setup
Theme: Twenty Fifteen
Active Plugins: BP v12.0.0-beta1 & BuddyPress RESTful API

Change History (5)

#1 @imath
8 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 12.0.0

Hi @vapvarun

Thanks for your feedback, I had a similar issue when displaying the activity permalink view. My first guess is I forgot to register this Ajax action in the new registration process I introduced with BP Rewrites API to avoid using WP() at each Ajax call.

I will look at it asap.

Last edited 8 months ago by imath (previous) (diff)

#2 @imath
8 months ago

I confirm the issue. It's not what I initially thought of. I will submit a patch asap and provide more explanations along with it.

This ticket was mentioned in PR #150 on buddypress/buddypress by @imath.


8 months ago
#3

  • Keywords has-patch added; needs-patch removed

To make sure the Messages component's view action is not considered as a 404, we now need to register it as a Member's navigation item without rendering it once the query is parsed. This move also allows site administrators to customize this action's slug from the URLs BuddyPress settings tab.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/8975

#4 @imath
8 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13551:

Messages: include the view action in registered Member Nav sub-items

o make sure the Messages component's view action is not considered as a
404, we now need to register it as a Member's navigation sub-item without
rendering it once the query is parsed.

This move also allows site administrators to customize this action's slug
from the URLs BuddyPress settings tab.

Props vapvarun

Fixes #8975
Closes https://github.com/buddypress/buddypress/pull/150

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


8 months ago

Note: See TracTickets for help on using tickets.