Skip to:
Content

BuddyPress.org

#8895 closed task (fixed)

Only deprecate some functions if BP Classic is not active

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 12.0.0 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch
Cc:

Description

12.0.0 is deprecating a lot of functions that Plugins might be using for a while. These deprecation notices are an interesting way to figure out the BP Classic plugin is needed.

Once the BP Classic plugin is activated, we then need to make sure these deprecation notices are not shown anymore, because:

  • BP Classic include these functions
  • BP Classic forces the Site to use pretty permalinks
  • BP Classic forces the usage of the Legacy URL parser, so it's safe to add URL chunks behind functions building URLs.

This is achieved by putting deprecated functions behind a ! function_exists( 'bp_classic' ) check.

This task wasn't fully performed in #4954

Change History (2)

This ticket was mentioned in PR #101 on buddypress/buddypress by @imath.


10 months ago
#1

  • Keywords has-patch added; needs-patch removed

Move some deprecated functions behind a specific check.
If BP Classic is active these functions won't need to throw deprecation notices.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/8895

#2 @imath
10 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13477:

Move some 12.0.0 deprecated functions behind a BP Classic plugin check

The BP Classic plugin will include these deprecated functions as the plugin is forcing the BP Legacy URL parser usage & pretty permalinks.

Fixes #8895

Note: See TracTickets for help on using tickets.