Skip to:
Content

BuddyPress.org

Opened 22 months ago

Last modified 9 months ago

#8722 assigned enhancement

Introduce a new specific template pack "BP reNouveau"

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: Under Consideration Priority: normal
Severity: normal Version:
Component: Templates Keywords:
Cc:

Description

After exploring potential impacts about our will to remove our dependency to jQuery, I think the best approach is to build a new template pack to make this happen. This template pack will be a bit specific though.

It will be like an evolution of BP Nouveau. « BP reNouveau » (FYI: nouveau is the French for new and renouveau is the French for renewal) will keep all Nouveau look and feel (CSS & HTML layouts) to save us some precious time into this area. We will also be able to avoid code/template duplication by using Nouveau as a fallback.

Doing so we can focus on using modern JavaScript along with the BP REST API instead of Ajax calls.

The Members directory is almost ready. As soon as I think it is, I'll share a GH Pull Request into this ticket.

This work will also help us to improve the BP REST API, I already shared a GH issue working on the Members directory.

Attachments (1)

8722.patch (3.8 KB) - added by imath 21 months ago.

Download all attachments as: .zip

Change History (14)

#1 @shanebp
21 months ago

Marketing suggestion - BP reNouveau is too similar and too easily confused with BP Nouveau.
It's new, it's different, it's modern, market that aspect with a new name.
Ex: BP ala mode, BP Vogue

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


21 months ago

#3 @imath
21 months ago

In 13299:

Introduce a function to only get the Public Message button arguments

BP Nouveau is doing a complex workaround to only get these arguments without generating the BP_Button HTML output. bp_activity_get_public_message_button_args() eases the process of getting these arguments and removes the need for such a workaround.

Props hnla

See #7126
See #8722

#4 @imath
21 months ago

In 13300:

Introduce a function to only get the Private Message button arguments

bp_get_send_message_button_args() eases the process of getting these arguments and removes the need for BP Nouveau's workaround.

Props hnla

See #7126
See #8722

#5 @imath
21 months ago

In 13301:

Introduce a function to only get the Friendship button arguments

bp_get_add_friend_button_args() eases the process of getting these arguments and removes the need for BP Nouveau's workaround.
Deprecate the bp_nouveau_members_catch_button_args() as no more needed.

Props hnla

See #7126
See #8722

#6 @imath
21 months ago

In 13302:

Introduce a function to only get the "Join/Leave Group" button args

bp_groups_get_group_join_button_args() eases the process of getting these arguments and removes the need for BP Nouveau's workaround.
Deprecate the bp_nouveau_groups_catch_button_args() as no more needed.

Props hnla

See #7126
See #8722

#7 @imath
21 months ago

In 13303:

Introduce a function to only get the "Visit blog" button args

bp_get_blogs_visit_blog_button_args() eases the process of getting these arguments and removes the need for BP Nouveau's workaround.
Deprecate the bp_nouveau_blogs_catch_button_args() as no more needed.

Props hnla

Fixes #7126
See #8722

#8 @imath
21 months ago

[13302] introduced a regression when viewing a group with the creator. I'm adding a patch about it right away to remember I need to commit it.

@imath
21 months ago

#9 @imath
21 months ago

In 13310:

Be sure the join/leave group button args exist before trying to use it

This is a follow up to [13302]. When the group creator is displaying the corresponding group's pages, the "join/leave group" header's button is not generated. In [13302], we were wrongly trying to access the arguments of this button although they do not exist. In this particular case, we just need to only perform BP Nouveau's button reset when this button is generated: that is to say when someone else than the creator is viewing a group's page.

See #8722

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


21 months ago

#11 @imath
19 months ago

  • Milestone changed from 11.0.0 to Up Next

Unfortunately, I wasn't able to find time to progress more about it and 11.0.0's first beta is very soon. We need to postpone this ticket to next milestone.

#12 @imath
16 months ago

  • Milestone changed from Up Next to 12.0.0

#13 @imath
9 months ago

  • Milestone changed from 12.0.0 to Under Consideration
  • Priority changed from high to normal

The more I think about it, the more I believe, the priority might not be to have a new template pack but a BP Standalone Block Theme: https://github.com/buddypress/buddyvibes.

Note: See TracTickets for help on using tickets.