Changeset 13310

Timestamp:

08/08/2022 09:46:33 PM (4 years ago)

Author:

imath

Message:

Be sure the join/leave group button args exist before trying to use it

This is a follow up to [13302]. When the group creator is displaying the corresponding group's pages, the "join/leave group" header's button is not generated. In [13302], we were wrongly trying to access the arguments of this button although they do not exist. In this particular case, we just need to only perform BP Nouveau's button reset when this button is generated: that is to say when someone else than the creator is viewing a group's page.

See #8722

File:

• trunk/src/bp-templates/bp-nouveau/includes/groups/template-tags.php (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/includes/groups/template-tags.php

@@ -999 +999 @@
                         $button_args = bp_groups_get_group_join_button_args( $group );
 
-                        // If we pass through parent classes merge those into the existing ones
-                        if ( $parent_class ) {
-                                $parent_class .= ' ' . $button_args['wrapper_class'];
-                        }
-
-                        // The join or leave group header button should default to 'button'
-                        // Reverse the earler button var to set default as 'button' not 'a'
-                        if ( empty( $args['button_element'] ) ) {
-                                $button_element = 'button';
-                        }
-
-                        $buttons['group_membership'] = array(
-                                'id'                => 'group_membership',
-                                'position'          => 5,
-                                'component'         => $button_args['component'],
-                                'must_be_logged_in' => $button_args['must_be_logged_in'],
-                                'block_self'        => $button_args['block_self'],
-                                'parent_element'    => $parent_element,
-                                'button_element'    => $button_element,
-                                'link_text'         => $button_args['link_text'],
-                                'link_title'        => $button_args['link_title'],
-                                'parent_attr'       => array(
-                                                'id'    => $button_args['wrapper_id'],
-                                                'class' => $parent_class,
-                                ),
-                                'button_attr'       => array(
-                                        'id'    => ! empty( $button_args['link_id'] ) ? $button_args['link_id'] : '',
-                                        'class' => $button_args['link_class'] . ' button',
-                                        'rel'   => ! empty( $button_args['link_rel'] ) ? $button_args['link_rel'] : '',
-                                        'title' => '',
-                                ),
-                        );
-
-                        // If button element set add nonce 'href' link to data-attr attr.
-                        if ( 'button' === $button_element ) {
-                                $buttons['group_membership']['button_attr']['data-bp-nonce'] = $button_args['link_href'];
-                        } else {
-                        // Else this is an anchor so use an 'href' attr.
-                                $buttons['group_membership']['button_attr']['href'] = $button_args['link_href'];
+                        if ( $button_args ) {
+                                // If we pass through parent classes merge those into the existing ones.
+                                if ( $parent_class ) {
+                                        $parent_class .= ' ' . $button_args['wrapper_class'];
+                                }
+
+                                // The join or leave group header button should default to 'button'.
+                                // Reverse the earlier button var to set default as 'button' not 'a'.
+                                if ( empty( $args['button_element'] ) ) {
+                                        $button_element = 'button';
+                                }
+
+                                $buttons['group_membership'] = array(
+                                        'id'                => 'group_membership',
+                                        'position'          => 5,
+                                        'component'         => $button_args['component'],
+                                        'must_be_logged_in' => $button_args['must_be_logged_in'],
+                                        'block_self'        => $button_args['block_self'],
+                                        'parent_element'    => $parent_element,
+                                        'button_element'    => $button_element,
+                                        'link_text'         => $button_args['link_text'],
+                                        'link_title'        => $button_args['link_title'],
+                                        'parent_attr'       => array(
+                                                        'id'    => $button_args['wrapper_id'],
+                                                        'class' => $parent_class,
+                                        ),
+                                        'button_attr'       => array(
+                                                'id'    => ! empty( $button_args['link_id'] ) ? $button_args['link_id'] : '',
+                                                'class' => $button_args['link_class'] . ' button',
+                                                'rel'   => ! empty( $button_args['link_rel'] ) ? $button_args['link_rel'] : '',
+                                                'title' => '',
+                                        ),
+                                );
+
+                                // If button element set add nonce 'href' link to data-attr attr.
+                                if ( 'button' === $button_element ) {
+                                        $buttons['group_membership']['button_attr']['data-bp-nonce'] = $button_args['link_href'];
+                                } else {
+                                        // Else this is an anchor so use an 'href' attr.
+                                        $buttons['group_membership']['button_attr']['href'] = $button_args['link_href'];
+                                }
                         }
                 }