Skip to:

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#8497 closed enhancement (fixed)

Allow detecting button element with bp_nouveau_get_members_buttons and bp_nouveau_get_groups_buttons

Reported by: sbrajesh's profile sbrajesh Owned by: imath's profile imath
Milestone: 9.0.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: has-patch commit


Currently, if 3rd party code wants to add extra buttons using the above 2 filters, they do not know if they should use button or anchor element.
These filters should pass the user passed $args to allow the detection of button element being used.

Please find the patch atatched.

Attachments (1)

8497.diff (1.7 KB) - added by sbrajesh 3 years ago.

Download all attachments as: .zip

Change History (4)

3 years ago

#1 @imath
3 years ago

  • Component changed from (not sure) to Templates
  • Keywords commit added
  • Milestone changed from Awaiting Review to 9.0.0
  • Version changed from 8.0.0 to 3.0.0

Thanks @sbrajesh for your suggestion & patch. It looks good 👍

#2 @imath
3 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12979:

Pass expected arguments to Members/Groups Action button filters

To improve extensibility of the 2 functions BP Nouveau uses to generate these action buttons (bp_nouveau_get_members_buttons() & bp_nouveau_get_groups_buttons()), we are adding a new $args parameter to their corresponding filters ('bp_nouveau_get_members_buttons'& 'bp_nouveau_get_groups_buttons').

Doing so should help developers to have better information about the expected output for these buttons.

Props sbrajesh

Fixes #8497

#3 @sbrajesh
3 years ago

Thank you.

Note: See TracTickets for help on using tickets.