Opened 4 years ago
Closed 4 years ago
#8437 closed defect (bug) (fixed)
'bp_core_avatar_default' filter is used twice, but for different purposes
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 8.0.0 | Priority: | normal |
Severity: | normal | Version: | 2.6.0 |
Component: | Core | Keywords: | dev-feedback has-patch 2nd-opinion needs-docs |
Cc: |
Description (last modified by )
In r10688, the 'bp_core_avatar_default'
filter was introduced for a second time, but is used for a different purpose (see #6989). That filter is used in the generation of the Gravatar URL. We should rename this filter because it is causing a conflict when the real 'bp_core_avatar_default'
filter is used. Perhaps rename the filter to 'bp_core_avatar_gravatar_default'
?
The 'bp_core_avatar_default'
filter was actually introduced back in BuddyPress 2.0 in r7769.
Attachments (1)
Change History (5)
#3
@
4 years ago
- Keywords has-patch 2nd-opinion needs-docs added; needs-patch removed
In 8347.patch I'm deprecating both filters and add some checks to see if the value is a default Gravatar or an URL to an avatar to eventually use the filtered value.
Hi r-a-y,
Good catch 💪. Is there a way to know the purpose the filter was used for and then simply doing a doing_it_wrong feedback for one of the purpose or should we deprecate both filters ?