Opened 4 years ago
Closed 4 years ago
#8432 closed defect (bug) (fixed)
PHPUnit tests about media in WP Trunk (5.7 dev cycle)
Reported by: | imath | Owned by: | imath |
---|---|---|---|
Milestone: | 7.2.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch |
Cc: |
Description
If you look at this log file from Travis CI, you'll see that it gets 4 errors with PHP 5.6 and WP Trunk.
If you look at this other log file from Travis CI, you'll see that it gets 1 error with PHP > 5.6 and WP Trunk.
This happens when testing against WP Trunk because of this commit. Now when you don't have the WP_RUN_CORE_TESTS
constant set to true, errors about exif_read_data()
and getimagesize()
are not silenced anymore. I've tested defining this constant, it's worse, we get 43 failing tests.
I've been looking for an explanation about why exif_read_data()
is generating an error in PHP 5.6 and not in newer PHP version. After looking for some time about it, it looks like PHP 5.6 has an unresolved bug about it :(
To fix the getimagesize()
case, we simply need to put files into the /wp-uploads
directory, test_extract_images_from_content_with_galleries_variant_ids()
wasn't so I've edited it into the attached patch.
In 12840: