Changeset 12841

Timestamp:

02/06/2021 08:39:28 PM (4 years ago)

Author:

imath

Message:

PHPUnit: fix failing tests about media

Since WP ​50170 revision, errors about getimagesize() and exif_read_data() are not silenced anymore. We must now make sure to write media files where they should be for these two functions.

Tests involving exif_read_data() will be skipped from now on when testing against PHP 5.6 as no matter the image you use, you'll always get an Illegal IDF size error. It appears to be a bug with this version of PHP.

Fixes #8432 (7.0 branch)

Location:

branches/7.0/tests/phpunit

Files:

• assets/canola.jpg (added)
• assets/test-image-large.jpg (added)
• testcases/core/class-bp-attachment.php (modified) (3 diffs)
• testcases/core/class-bp-media-extractor.php (modified) (2 diffs)

branches/7.0/tests/phpunit/testcases/core/class-bp-attachment.php

@@ -378 +378 @@
      */
     public function test_bp_attachment_avatar_shrink() {
-        if ( false === _wp_image_editor_choose() ) {
-            $this->markTestSkipped( 'This test requires PHP to have a valid image editor that is compatible with WordPress.' );
+        if ( false === _wp_image_editor_choose() || version_compare( phpversion(), '7.0' , '<' ) ) {
+            $this->markTestSkipped( 'This test requires PHP >= 7.0 and to have a valid image editor that is compatible with WordPress.' );
         }
 
@@ -430 +430 @@
         }
 
-        $image = BP_TESTS_DIR . 'assets/upside-down.jpg';
+        $image = BP_TESTS_DIR . 'assets/test-image-large.jpg';
 
         $cover_image_class = new BP_Attachment_Cover_Image();
 
-        $abs_path_copy = $cover_image_class->upload_path . '/upside-down.jpg';
+        $abs_path_copy = $cover_image_class->upload_path . '/test-image-large.jpg';
 
         copy( $image, $abs_path_copy );
@@ -465 +465 @@
      */
     public function test_bp_attachment_get_image_data() {
-        if ( ! is_callable( 'exif_read_data' ) ) {
-            $this->markTestSkipped( 'This test requires PHP to be compiled with EXIF support.' );
+        if ( ! is_callable( 'exif_read_data' ) || version_compare( phpversion(), '7.0' , '<' ) ) {
+            $this->markTestSkipped( 'This test requires PHP >= 7.0 and to be compiled with EXIF support.' );
         }
 

branches/7.0/tests/phpunit/testcases/core/class-bp-media-extractor.php

@@ -322 +322 @@
 
     public function test_extract_images_from_content_with_galleries_variant_ids() {
-        $attachment_ids   = array();
-        $attachment_ids[] = $this->fake_attachment_upload( DIR_TESTDATA . '/images/test-image-large.png' );
-        $attachment_ids[] = $this->fake_attachment_upload( DIR_TESTDATA . '/images/canola.jpg' );
-        $attachment_ids   = join( ',', $attachment_ids );
-        $post_id          = self::factory()->post->create( array( 'post_content' => "[gallery ids='{$attachment_ids}']" ) );
+        $attachment_ids = array(
+            'large'  => 0,
+            'canola' => 0,
+        );
+
+        $attachment_ids['large'] = self::factory()->attachment->create_upload_object( BP_TESTS_DIR . 'assets/test-image-large.jpg' );
+        $attachment_ids['canola'] = self::factory()->attachment->create_upload_object( BP_TESTS_DIR . 'assets/canola.jpg' );
+
+        $attachments = join( ',', $attachment_ids );
+        $post_id     = self::factory()->post->create( array( 'post_content' => "[gallery ids='{$attachments}']" ) );
 
         // Extract the gallery images.
@@ -337 +342 @@
         $this->assertCount( 2, $media );
 
-        $this->assertSame( WP_CONTENT_URL . '/uploads/test-image-large.png', $media[0]['url'] );
-        $this->assertSame( WP_CONTENT_URL . '/uploads/canola.jpg', $media[1]['url'] );
+        $expected_urls = array(
+            'large'  => wp_get_attachment_url( $attachment_ids['large'] ),
+            'canola' => wp_get_attachment_url( $attachment_ids['canola'] ),
+        );
+
+        $this->assertSame( $expected_urls['large'], $media[0]['url'] );
+        $this->assertSame( $expected_urls['canola'], $media[1]['url'] );
     }