Skip to:
Content

BuddyPress.org

Opened 4 months ago

Closed 4 weeks ago

#8272 closed defect (bug) (fixed)

Private groups not available in group block

Reported by: iamthewebb Owned by: imath
Milestone: 7.0.0 Priority: normal
Severity: normal Version:
Component: REST API Keywords: has-patch commit
Cc:

Description

I created an empty WP site with only v6.0.0 of BP installed. I created one of each group type.
The public group can be selected in the new Group Blocks but both Private and Hidden groups do not appear to be selected.

Description of Private groups

Only people who request membership and are accepted can join the group.
This group will be listed in the groups directory and in search results.
Group content and activity will only be visible to members of the group.

I don't think this would be circumvented by having the Private groups available for selection?

Attachments (1)

8272.patch (11.0 KB) - added by imath 4 weeks ago.

Download all attachments as: .zip

Change History (7)

#1 @imath
4 months ago

  • Keywords dev-feedback added

Hi @iamthewebb

Thanks for your feedback. It's a deliberate choice I've made. To me featuring a private group into a Post or a Page doesn't seem to be a great experience for the site's visitors. Once they click on the Group's link, they can't see more than what's into the BP Group Block.

But, I'm very open to change this if other members of the team think it's a better idea to also include private groups.

#2 @imath
4 months ago

  • Milestone changed from 6.0.0 to Up Next

I believe we're running out of time about this ticket for 6.0.0. Let's work on it during next development cycle.

#3 @imath
3 months ago

  • Milestone changed from Up Next to 7.0.0

@imath
4 weeks ago

#4 @imath
4 weeks ago

  • Component changed from (not sure) to REST API
  • Keywords has-patch needs-testing added; dev-feedback removed

Ok @iamthewebb let's also include Private groups into the Autocompleter!

In 8272.patch, I've improved various things about BP Blocks actually.

  1. Adapt to the Block Editor's new style to arrive in WordPress 5.5
  2. Improve the bp.Autocompleter component so that it's more useful. We can now use it to send specific query args to the endpoint and a callback function to display the item slug.
  3. Improve the BP Group block so that it use these query args { 'show_hidden': false } meaning Private and Public groups can be listed into the Autocompleter.
  4. Improve both blocks (Group and member) so that they use the slug callback function to respectively display the Group status and the member's mention name.

Here's a preview:

https://cldup.com/QYYt7ngPUK.png

I haven't tested it into WordPress < 5.5. I'll give it a check asap. @iamthewebb don't hesitate to test it ;)

#5 @imath
4 weeks ago

  • Keywords commit added; needs-testing removed

I've just tested using WordPress 5.4.2. It's looking fine. I'll commit it asap.

#6 @imath
4 weeks ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12684:

BP Blocks: Include private Groups into the BP Group Autocompleter

So far the BP Group block was only listed public group. Thanks to some improvements about the BP Autocompleter React component, we are now also including private groups.

This commit also includes some other improvements:

  • Prepare BP Blocks for the Block Editor's style changes to be introduced into WordPress 5.5.
  • Improve the BP Autocompleter React component so that it's more useful. We can now use it to send specific query arguments to the BP component's endpoint and use callback function to return the Component's item slug.
  • Improve both blocks (Group and member) so that they use this slug callback function to respectively display the Group status and the Member's mention name.

Props iamthewebb

Fixes #8272

Note: See TracTickets for help on using tickets.