Nouveau avatar rounding incorrectly

[iamthewebb]

Clean install of WP 5.4 BP 5.1.2 or 6.0 beta1 (seems to apply to all recent versions of BP) using Twenty Twenty theme.

Avatars for Groups and Members are square by default using the default One Column loops, when you change this to Two column or more the Group and Member images are change to circular.
There is a setting within General BP Settings -> Use the round style for member and group avatars but this is being ignored by these layouts.

Also in the new Blocks for Groups and Members this setting is also ignored, feels a bit disjointed to have a setting that only applies to some parts of a site.

[imath]

Thanks a lot for your feedback. I agree. I believe we shouldn't try to play with the avatar style and leave the theme completely handle it. So I'd probably remove the BP Nouveau Customizer setting. Let's take some time to think about it during next release.

[imath]

Ouch. We couldn't progress about this during 8.0.0. Let's try to do so during next major release.

Let the theme deal with Avatar style so that it's rendered consistently everywhere on the site.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8273

[imath]

I failed at referencing this ticket in this ​commit But it's fixed 😅