Skip to:

Opened 4 years ago

Closed 5 months ago

#8273 closed defect (bug) (fixed)

Nouveau avatar rounding incorrectly

Reported by: iamthewebb's profile iamthewebb Owned by:
Milestone: 12.0.0 Priority: normal
Severity: normal Version: 5.0.0
Component: Templates Keywords: has-patch


Clean install of WP 5.4 BP 5.1.2 or 6.0 beta1 (seems to apply to all recent versions of BP) using Twenty Twenty theme.

Avatars for Groups and Members are square by default using the default One Column loops, when you change this to Two column or more the Group and Member images are change to circular.
There is a setting within General BP Settings -> Use the round style for member and group avatars but this is being ignored by these layouts.

Also in the new Blocks for Groups and Members this setting is also ignored, feels a bit disjointed to have a setting that only applies to some parts of a site.

Change History (7)

#1 @imath
4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Up Next

Thanks a lot for your feedback. I agree. I believe we shouldn't try to play with the avatar style and leave the theme completely handle it. So I'd probably remove the BP Nouveau Customizer setting. Let's take some time to think about it during next release.

#2 @imath
3 years ago

  • Milestone changed from Up Next to 8.0.0

This ticket was mentioned in Slack in #buddypress by vapvarun. View the logs.

3 years ago

#4 @imath
3 years ago

  • Milestone changed from 8.0.0 to Up Next

Ouch. We couldn't progress about this during 8.0.0. Let's try to do so during next major release.

#5 @imath
11 months ago

  • Milestone changed from Up Next to 12.0.0

This ticket was mentioned in PR #141 on buddypress/buddypress by @imath.

5 months ago

  • Keywords has-patch added; needs-patch removed

Let the theme deal with Avatar style so that it's rendered consistently everywhere on the site.

Trac ticket:

#7 @imath
5 months ago

  • Resolution set to fixed
  • Status changed from new to closed

I failed at referencing this ticket in this commit But it's fixed 😅

Note: See TracTickets for help on using tickets.