Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#8197 closed defect (bug) (fixed)

src\bp-core\admin\bp-core-admin-functions.php coding standard mistakes

Reported by: sharaz's profile sharaz Owned by: slaffik's profile slaFFik
Milestone: 6.0.0 Priority: normal
Severity: normal Version: 5.0.0
Component: Administration Keywords: has-patch commit
Cc:

Description

According to the WordPress coding standards. I noticed there lot of mistakes like improper use of coma with the array, Do Block comment extra line, printf improper arguments and indentation mistakes.

Attachments (2)

8197.patch (21.1 KB) - added by sharaz 4 years ago.
1.8197.patch (20.8 KB) - added by sharaz 4 years ago.

Download all attachments as: .zip

Change History (5)

@sharaz
4 years ago

@sharaz
4 years ago

#1 @imath
4 years ago

  • Keywords has-patch reporter-feedback added; needs-patch removed
  • Milestone changed from Awaiting Review to 6.0.0

Hi @sharaz

Thanks for your contribution. Just to be sure is 1.8197.patch replacing 8197.patch ?

I believe we should discuss in a master ticket about adding WordPress Coding Standards tool to our build/test tools. And define like a strategy about cleaning "existing" code, just like we did for inline documentation. For example: do 1 component at a time.

For now I'll take a deeper look at your patch before 6.0 release.

#2 @imath
4 years ago

  • Component changed from Core to Administration
  • Keywords commit added; reporter-feedback removed
  • Owner set to slaFFik

It looks good. Let's have it in.

#3 @imath
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 12538:

Admin: fix PHP code standards (including Translators comments)

Props sharaz

Fixes #8197

Note: See TracTickets for help on using tickets.