src\class-buddypress.php coding standards mistakes

[sharaz]

Comments mistakes, Object initialization, indentation and more ...

[imath]

Thanks for your contribution and patch. Let's look at it during 6.0.0.

PS: I think @johnjamesjacoby 's opinion would be nice about code formatting changes.

[espellcaste]

Looking at the changes, I don't see possible breaking ones. The only thing I dislike is the alignmnet of the irregular_map classes. But the only reason is because adding new classes forces you to change everything rather than one line.

[espellcaste]

@imath or @jjj This seems ok to me. Any objections about the patch?

[imath]

Nothing on my side, but changes reformat a lot the file so I’d like @johnjamesjacoby ‘s opinion about it before moving forward.

[espellcaste]

@johnjamesjacoby Were you able to take a look?

[imath]

Let's try to work on this during next development cycle

[espellcaste]

Patch updated! Ready for another look! :)

[imath]

Looks good! Thanks for your work on this 👌

[espellcaste]

In 13109:

Making PHPDoc Improvements to the class-buddypress.php file.

Also, adding several minor PHP changes.

Props imath

Fixes #8198 and see #8553