Opened 5 years ago
Closed 3 years ago
#8198 closed enhancement (fixed)
src\class-buddypress.php coding standards mistakes
Reported by: | sharaz | Owned by: | espellcaste |
---|---|---|---|
Milestone: | 10.0.0 | Priority: | normal |
Severity: | normal | Version: | 5.0.0 |
Component: | Core | Keywords: | has-patch |
Cc: |
Description
Comments mistakes, Object initialization, indentation and more ...
Attachments (2)
Change History (15)
#4
@
4 years ago
- Keywords needs-refresh added; 2nd-opinion removed
- Milestone changed from Up Next to 7.0.0
- Owner set to espellcaste
- Status changed from new to assigned
- Type changed from defect (bug) to enhancement
Looking at the changes, I don't see possible breaking ones. The only thing I dislike is the alignmnet of the irregular_map
classes. But the only reason is because adding new classes forces you to change everything rather than one line.
#5
@
4 years ago
- Keywords needs-refresh removed
@imath or @jjj This seems ok to me. Any objections about the patch?
#6
@
4 years ago
Nothing on my side, but changes reformat a lot the file so I’d like @johnjamesjacoby ‘s opinion about it before moving forward.
Note: See
TracTickets for help on using
tickets.
Thanks for your contribution and patch. Let's look at it during 6.0.0.
PS: I think @johnjamesjacoby 's opinion would be nice about code formatting changes.