Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 3 years ago

#8198 closed enhancement (fixed)

src\class-buddypress.php coding standards mistakes

Reported by: sharaz's profile sharaz Owned by: espellcaste's profile espellcaste
Milestone: 10.0.0 Priority: normal
Severity: normal Version: 5.0.0
Component: Core Keywords: has-patch
Cc:

Description

Comments mistakes, Object initialization, indentation and more ...

Attachments (2)

8198.patch​ (21.6 KB) - added by sharaz 5 years ago.
8198-1.diff​ (28.3 KB) - added by espellcaste 3 years ago.

Download all attachments as: .zip

Change History (15)

@sharaz
5 years ago

#1 @sharaz
5 years ago

  • Keywords has-patch added

#2 @imath
5 years ago

  • Keywords 2nd-opinion added
  • Milestone changed from Awaiting Review to 6.0.0

Thanks for your contribution and patch. Let's look at it during 6.0.0.

PS: I think @johnjamesjacoby 's opinion would be nice about code formatting changes.

#3 @imath
5 years ago

  • Milestone changed from 6.0.0 to Up Next

#4 @espellcaste
5 years ago

  • Keywords needs-refresh added; 2nd-opinion removed
  • Milestone changed from Up Next to 7.0.0
  • Owner set to espellcaste
  • Status changed from new to assigned
  • Type changed from defect (bug) to enhancement

Looking at the changes, I don't see possible breaking ones. The only thing I dislike is the alignmnet of the irregular_map classes. But the only reason is because adding new classes forces you to change everything rather than one line.

Last edited 4 years ago by espellcaste (previous) (diff)

#5 @espellcaste
4 years ago

  • Keywords needs-refresh removed

@imath or @jjj This seems ok to me. Any objections about the patch?

#6 @imath
4 years ago

Nothing on my side, but changes reformat a lot the file so I’d like @johnjamesjacoby ‘s opinion about it before moving forward.

#7 @espellcaste
4 years ago

@johnjamesjacoby Were you able to take a look?

#8 @imath
4 years ago

  • Milestone changed from 7.0.0 to Up Next

Let's try to work on this during next development cycle

#9 @espellcaste
3 years ago

  • Keywords needs-refresh added
  • Milestone changed from Up Next to 10.0.0

@espellcaste
3 years ago

#10 @espellcaste
3 years ago

Patch updated! Ready for another look! :)

#11 @espellcaste
3 years ago

  • Keywords needs-refresh removed

#12 @imath
3 years ago

Looks good! Thanks for your work on this 👌

#13 @espellcaste
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13109:

Making PHPDoc Improvements to the class-buddypress.php file.

Also, adding several minor PHP changes.

Props imath

Fixes #8198 and see #8553

Note: See TracTickets for help on using tickets.