Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#8145 closed enhancement (wontfix)

Fixed legacy layout issue in registration page

Reported by: zishanj's profile zishanj Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch dev-feedback
Cc:

Description

Added css class div layout-wrap which will make layout in flex making the registration page appear in 2 columns on big screen.
Added filter bp_get_user_activation_feedback to change the default registration success message.

Attachments (2)

register-layout.diff (1.4 KB) - added by zishanj 4 years ago.
register-layout.2.diff (1.4 KB) - added by zishanj 4 years ago.
added spaces

Download all attachments as: .zip

Change History (12)

#1 @zishanj
4 years ago

  • Milestone Awaiting Review deleted

#2 @imath
4 years ago

  • Keywords has-patch added
  • Milestone set to Awaiting Review

#3 @imath
4 years ago

  • Keywords 2nd-opinion added

About this one : layout-wrap is not a BuddyPress class. I guess it comes from your theme. So it's a no go.

About the filter I think I'd rather split the template to allow the template override of the confirmation part.

FYI you can already completely override the template from the active theme:
see https://codex.buddypress.org/themes/theme-compatibility-1-7/template-hierarchy/

#4 @zishanj
4 years ago

layout-wrap is actually defined in bp-nouveau template and I have copied these css styles to my local css:

@media screen and (min-width:46.8em) {
    #buddypress #register-page .layout-wrap {
        display: flex;
        flex-flow: row wrap;
        justify-content: space-around
    }

    #buddypress #register-page .layout-wrap #basic-details-section {
        flex: 1;
        padding-right: 2em;
        border: none;
    }

    #buddypress #register-page .layout-wrap #profile-details-section {
        flex: 1;
        padding-left: 2em;
        border: none;
    }
}

I guess legacy template should also have this responsive support. May be we can also add this to buddypress.css file of legacy template.

Regarding overriding the template, I couldn't found the path and filenames mentioned at https://codex.buddypress.org/themes/theme-compatibility-1-7/template-hierarchy/

#5 @zishanj
4 years ago

Btw. I guess templates should be capable of supporting small tweaks using filter instead of overriding entire template file.

@zishanj
4 years ago

added spaces

#6 @imath
4 years ago

  • Keywords dev-feedback added; 2nd-opinion removed

Btw. I guess templates should be capable of supporting small tweaks using filter instead of overriding entire template file.

That's why I was wondering about spliting the template...

I believe how it's done within the BP Nouveau template pack make it easier to customize this feedback message.

I believe legacy should only be fixed and not improved (But I'd like the opinion of other members of the team about this).

I advise you to override the register template from within your theme :

/theme-name/buddypress/members/register.php < this is the place where to copy/paste the template.

#7 @zishanj
4 years ago

Minor improvements like making registration page responsive with flex and adding one filter will be appreciated from new user to kick start the BuddyPress. :)

#8 @imath
4 years ago

It's already the case :)
By default on new installs the active template pack is BP Nouveau.

#9 @zishanj
4 years ago

Ok... I am using BuddyPress with BuddyBoss SocialLearner theme and they only have option for legacy template at the moment. If this minor improvement will be made then it will be easy for us instead of overriding the template.

Last edited 4 years ago by zishanj (previous) (diff)

#10 @imath
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Overriding the template or asking BuddyBoss to support BP Nouveau is the way to go. BP Legacy should only updated when there's back compatibility issues imho.

Note: See TracTickets for help on using tickets.