bp_get_group_is_public() always returns NULL

[mattjones2207]

It seems that the bp_get_group_is_public() function checks for $group->is_public property, but this does not exist in the BP_Groups_Group class.

Either this should be handled internally in the BP_Groups_Group class, or these functions should be checking the value of the $group->status property?

Also affected:

bp_group_is_public()
bp_get_group_public_status()
bp_group_public_status()

[imath]

Hi @mattjones2207

Thanks for your feedback. There's a comment inside some of these functions saying there are not used anymore. But I agree we should deprecate them asap.

To get the group status from within a groups loop, you can use bp_get_group_status( $group ) to know if it's a public one you should be able to do 'public' === bp_get_group_status( $group )

[imath]

8146.patch is deprecating the functions.

[mattjones2207]

Thanks @imath! I did stumble across the bp_get_group_status() function in the end :)

[espellcaste]

@imath Another easy win for 6.0 which I think it is ready to be commited.

[imath]

Sure but now I've created a deprecated/6.0.php file for #8156 The patch needs a refresh.

[imath]

Patch has been refreshed. Let's commit it.

[imath]

In 12568:

Groups: deprecate 4 functions no more used in BuddyPress

Deprecated functions are:

• bp_group_public_status()
• bp_get_group_public_status()
• bp_group_is_public()
• bp_get_group_is_public()

Props mattjones2207, espellcaste

Fixes #8146