#8143 closed enhancement (fixed)
Ability to customize Manage Signups page in admin
Reported by: | zishanj | Owned by: | imath |
---|---|---|---|
Milestone: | 6.0.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Members | Keywords: | has-patch 2nd-opinion |
Cc: |
Description
Added 2 actions:
bp_signups_admin_columns Add additional columns in Manage Signups table. It accepts 1 parameter $signup which gives user signup data.
bp_signupn_admin_fields Add additional fields on Manage Signups page after table. Accepts 1 parameter $signup->signup_id.
Attachments (2)
Change History (10)
#2
@
5 years ago
bp_members_signup_columns is used on bp-signups/Pending page where it list all the users in table. bp_signups_admin_columns will work on next page when admin click on the user. This is the page where admin can finally Confirm the user. I have used this bp_signups_admin_fields action name for clarity purposes because it makes possible to add section below the table. May be we can rename it to bp_signups_admin_section or something else.
I have created the screenshot (https://i.paste.pics/6YKHD.png) to further clarify the things.
#3
@
5 years ago
- Keywords has-patch 2nd-opinion added
- Milestone changed from Awaiting Review to 6.0.0
Thanks a lot for these details. I guess I've jumped too quick on what was the "Manage Signups table" :)
Ok, let's add these hooks. As it's possible to list more than one signup there. Let's take some time to think about better names for the 2 hooks and improve the position of the first one.
imho: it should be out of the if statement as if the xProfile component is not active it would be useless. So just above the </tbody>
tag seems a better place
This screen is used to confirm the activate/resend activation email and delete actions. What about something like bp_activate_signup_confirmation_details
for this first hook.
The second one still deals with the activate action so what do you think of bp_activate_signup_confirmation_after_details
?
#4
@
5 years ago
You are right. I have moved that hook outside the if statement. I think your suggested hook names are more meaningful. I will attach updated patch file.
#5
@
5 years ago
- Owner set to imath
- Resolution set to fixed
- Status changed from new to closed
In 12479:
Thanks a lot for your contribution @zishanj. I agree being able to add an admin column is needed for the Signups Table List. I think it's already possible using this filter
bp_members_signup_columns
to add a new column and this filterbp_members_signup_custom_column
to set the row values for this column. I'll check it again.About the
bp_signup_admin_fields
I think the name is confusing because I first thought it was about setting the xprofile field to display during the signup process.What about another name for this hook like
bp_after_signups_admin_list_table
?