Skip to:
Content

BuddyPress.org

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#8140 closed defect (bug) (fixed)

Some translation commands are missing

Reported by: szepe.viktor Owned by: imath
Milestone: 5.1.0 Priority: normal
Severity: major Version:
Component: I18N Keywords: has-patch
Cc:

Description

e.g. we have ~3×esc_html instead of esc_html_e

try issuing grep -rn "esc_html(.*'buddypress'"

Thank you.

Attachments (2)

8140.patch (2.3 KB) - added by imath 10 months ago.
8140.2.patch (3.1 KB) - added by imath 10 months ago.

Download all attachments as: .zip

Change History (11)

#1 @imath
10 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.1.0
  • Owner changed from slaFFik to imath
  • Status changed from new to assigned

Thanks for your feedback @szepeviktor

I've just performed a search and I confirm there are issues in this area. Some issues were introduced in 5.0.0, some others before.

@imath
10 months ago

#2 @imath
10 months ago

  • Keywords has-patch added; needs-patch removed

8140.patch should fix the issue.

#3 @szepe.viktor
10 months ago

What I remember is "Bulk Actions" in the notifications dropdown.

@imath
10 months ago

#4 @imath
10 months ago

8140.2.patch is taking care of this missing string

#5 @szepe.viktor
10 months ago

Thank you.

Do you plan to regenerate the .pot file?

#6 @imath
10 months ago

You're welcome. Yes I will regenerate it asap (once this ticket is fixed).

#7 @imath
10 months ago

In 12473:

i18n: fix typos in l10n function names

Example of typos:

  • esc_attr instead of esc_attr__,
  • esc_html instead of esc_html__,
  • esc_html instead of esc_html_e.

Props szepe.viktor

See #8140 (trunk)

#8 @imath
10 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 12474:

i18n: fix typos in l10n function names

Example of typos:

  • esc_attr instead of esc_attr__,
  • esc_html instead of esc_html__,
  • esc_html instead of esc_html_e.

Props szepe.viktor

Fixes #8140 (5.0 branch)

Note: See TracTickets for help on using tickets.