Confirmation for email change request is sent to the current email

[imath]

Since [10479], we are using the BP Email API for our notifications / confirmations. To send an email we use the bp_send_email( $email_type, $email_or_user_id, $tokens ) function. When using a user ID as the second parameter, the API will look for the user's current email.

When changing the email from the front end, we shouldn't use a user ID like it's the case since [10479], instead we should use the new email.

This issue comes form this support request: ​https://buddypress.org/support/topic/activation-email-sent-on-old-adresse-not-the-new-one/

[imath]

​8138.patch is fixing the issue:

• making sure we to customize the email salutation with the user displayname.
• behave like WordPress does.

[laudag]

I just tested your patch : It’s OK... Except one little thing that could be mistaken by the user : the message in buddypress profile page after changing the email adress is something like that (in french in my web site) : The modification of your email adress for “new mail” is pending. Watch your email “old email” to get activation link, or stop the pending modification.

Even if at last the user will receive the activation in his news mailbox, That could be misunderstood as only sent on the old email and… get support from me whereas it’s not necessary.

What do you think about that ?

Thanks for the patch anyway !

Replying to imath:

​8138.patch is fixing the issue:

• making sure we to customize the email salutation with the user displayname.
• behave like WordPress does.

[imath]

Are you sure @laudag because the part of the patch that edits src/bp-settings/bp-settings-template.php should fix this as it’s using the new email

[laudag]

Yes, I confirm. I did it again, and the same, even after deleting the browser cache.
The fact is that an other problemoito came out : To try again to change the mail and get the message in the page, I had to cancel the activation in the profile page.
After clic on "cancel pending modification", I get a "non found page", with the URL
​https://www.lanautique.com/vie-des-membres/espace-membres/membres/swbclaudag/settings/<Code>new mail</code>/
(swbclaudag, its me)

If I delete the patch line "'<code>' . esc_html( $pending_emailnewemail? ) . '</code>'," in bp-setting-template, I can cancel the pending modification.

Seems that it's not totally steady, no ?

Replying to imath:

Are you sure @laudag because the part of the patch that edits src/bp-settings/bp-settings-template.php should fix this as it’s using the new email

[imath]

For me, on a fresh install of WordPress & with no other plugins than BuddyPress activated, it behaves as expected, here's a screenshot of the screen notice:

[laudag]

Well... there must be something in my website which make a conflict. May be BuddyPress Xprofile Custom Field Types. Well, I miss time to check eveythings. At least people can validate their new email as they get the activation message. But this is weird.
Thanks

Replying to imath:

For me, on a fresh install of WordPress & with no other plugins than BuddyPress activated, it behaves as expected, here's a screenshot of the screen notice:

[espellcaste]

@imath This one seems to be good for 6.0. What do you think? The issue @laudag is mentioning seems to be related to their setup, and not related to your patch.

[imath]

Let's test the patch one more time before committing it.

[imath]

8138.2.patch is a refreshed version of the initial patch. I've just tested it another time and it works as expected. I'm going to commit it asap.

[imath]

In 12603:

Send the "email change" confirmation message to the new email

To be consistent with how the email change confirmation message is handled by WordPress, we need to send it to the new email and not to the current email.

Props laudag, espellcaste

Fixes #8138