Skip to:
Content

BuddyPress.org

Opened 6 months ago

Closed 6 months ago

#8092 closed enhancement (fixed)

BP Nouveau : use the WordPress Password control

Reported by: imath Owned by: imath
Milestone: 5.0.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description (last modified by imath)

Today one of a user of the corporate intranet I'm managing asked me :

Why the process to set your password is different when you go into the WordPress dashboard than when you go on the front-end into your account general setting screen ? It's a bit confusing...

And I must say I agree :)

That's why I'm suggesting to use the WordPress Password control in the attached patch. What do you think ?

Here is some screen captures :
https://cloudup.com/cfl8V8UFQ-Q

Attachments (2)

8092.patch (27.2 KB) - added by imath 6 months ago.
8092.2.patch (31.7 KB) - added by imath 6 months ago.

Download all attachments as: .zip

Change History (8)

@imath
6 months ago

#1 @imath
6 months ago

  • Description modified (diff)

#2 @boonebgorges
6 months ago

Sounds great to me.

#3 @dcavins
6 months ago

I think this would be a great improvement, too. Thanks, @imath!

#4 @imath
6 months ago

  • Keywords needs-testing added; 2nd-opinion removed

Thanks a lot for your feedbacks @boonebgorges & @dcavins. I'm going to run some more tests of the patch before adding it to Nouveau ;)

#5 @imath
6 months ago

  • Keywords needs-testing removed

In 8092.2.patch :

  • I've made sure to use escaped gettext functions in the general settings template
  • I've added the missing good strength indicator colors

I've also tested successfully the patch :

  • when a user edits his pwd on front-end.
  • when a user registers from the front-end.

I'll commit this new version of the patch soon. Thanks again for your feedbacks.

@imath
6 months ago

#6 @imath
6 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12397:

BP Nouveau: use the same control than WP to set the user password

On the BuddyPress registration page and on the general settings user’s page, BP Nouveau is now using the same control WordPress is using to let users choose their password. By default it generates a strong password to make the user aware of the importance of its robustness. The user can still edit it and if the password is too weak, the submit button is disabled until the user activates the checkbox to force the use of a weak password.

Developers, please note the src/bp-templates/bp-nouveau/js/password-verify.js is now deprecated and will be deleted in version 6.0.0. If you were using the bp-nouveau-password-verify script handle as a dependency of your script(s), please stop doing so before the 6.0.0 release.

Fixes #8092

Note: See TracTickets for help on using tickets.