Default avatar choices show same generated icon in general discussion settings

[netweblogic]

If you go to the Settings > Discussion settings page of WP, you'll notice all the avatar icons are the same generated icon according to the setting chosen.

For example, if your site default is Wavatar, all the choices show a Wavatar as an example.

The culprit is around line 653 of bp-core/bp-core-avatars.php

                $default_grav = apply_filters( 'bp_core_avatar_default', $default_grav, $params );

                // Only set default image if 'Gravatar Logo' is not requested.
                if ( 'gravatar_default' !== $default_grav ) {
                        $url_args['d'] = $default_grav;
                }

This does not respect the

$args['default']

argument provided by WordPress get_avatar() and

$url_args['d']

gets given an incorrect default gravatar for a regular user in the settings context.

[boonebgorges]

Thanks for the ticket. I'm fairly sure that this is a very old issue in BP - I've noticed it before but never bothered to try figuring it out :)

I had to do the following to fix it. See 8026.diff​:

1. If force_default, don't attempt to scan for uploaded images.
2. If force_default, ensure that the d param is set to default as passed from get_avatar()
3. Don't do the default_avatar override if force_default

@r-a-y Since you have touched this in the past, maybe you could give a brief review?

[imath]

Just looked at it. I confirm it's fixing the issue. Thanks a lot for your patch Boone 👌

[imath]

In 12417:

Avatars: make sure to respect the "force_default" argument

If "force_default" is true:

1. do not attempt to scan for uploaded images,
2. ensure that the d parameter is set to default as passed from get_avatar(),
3. Do not do the default_avatar override.

Props boonebgorges, netweblogic

Fixes #8026